Skip to content

Fix vec-to-vec conversion primitives#36

Merged
nabijaczleweli merged 1 commit into
nabijaczleweli:masterfrom
Enet4:bug/fix_vec_transmute_primitive
Nov 27, 2018
Merged

Fix vec-to-vec conversion primitives#36
nabijaczleweli merged 1 commit into
nabijaczleweli:masterfrom
Enet4:bug/fix_vec_transmute_primitive

Conversation

@Enet4

@Enet4 Enet4 commented Nov 24, 2018

Copy link
Copy Markdown
Collaborator

guarded_transmute_vec functions were using the wrong function parameter order for Vec::from_raw_parts. A critical bug, so I'd call for high priority on merging this.

- wrong function parameter order!
@Enet4 Enet4 added the bug label Nov 24, 2018
@nabijaczleweli nabijaczleweli merged commit a134e06 into nabijaczleweli:master Nov 27, 2018
@Enet4 Enet4 deleted the bug/fix_vec_transmute_primitive branch November 27, 2018 16:53
@nabijaczleweli

Copy link
Copy Markdown
Owner

Released in v0.10.1.

@Shnatsel

Shnatsel commented Mar 2, 2019

Copy link
Copy Markdown

It seems this bug could result in heap buffer overflow, which is a security vulnerability. Please file a security advisory in Rust security advisory database so that people could check if they're running a vulnerable version and upgrade.

@nabijaczleweli

Copy link
Copy Markdown
Owner

rustsec/advisory-db#89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants