Skip to content

Remove slurmdb from libs to link against for newer Slurm versions (>18)#34

Merged
natefoo merged 2 commits intonatefoo:masterfrom
EricR86:master
Mar 31, 2020
Merged

Remove slurmdb from libs to link against for newer Slurm versions (>18)#34
natefoo merged 2 commits intonatefoo:masterfrom
EricR86:master

Conversation

@EricR86
Copy link
Copy Markdown
Contributor

@EricR86 EricR86 commented Jan 3, 2020

This PR removes the libslurmdb library only in newer versions of SLURM as it was merged in with libslurm on versions of SLURM past 18.

The details of this change can be found under the "28 May 2019" section of the RELEASE_NOTES and can be found on the website.

Additionally, this also fixes a configure option when using --with-slurm-lib to point at a custom directory for SLURM libraries. Since this directory also contains the runtime libraries, the test in configure now includes that directory for runtime linking when testing the SLURM test program after compilation.

Fixes Issue #28

…ure path to shared object runtime path for testing availability
@natefoo
Copy link
Copy Markdown
Owner

natefoo commented Jan 23, 2020

I'm guessing this will need to be conditional based on the version of Slurm detected by autoconf?

@EricR86
Copy link
Copy Markdown
Contributor Author

EricR86 commented Jan 23, 2020

Depends if you want it to be conditional in the first place. This original fork presumably does not work with older versions of SLURM anyway correct?

It is possible just to make it conditional whether or not the slurmdb library is found though I'll have a hard time testing since I don't have access to both SLURM versions. Would you still prefer to build releases for both SLURM 19 and 18?

@natefoo
Copy link
Copy Markdown
Owner

natefoo commented Jan 23, 2020

This fork currently works with Slurm >= 16.05. I don't think we need to maintain compatibility back that far for new releases, but supporting at least the current oldest supported version of Slurm (18.08) would be ideal.

You can build a local copy of Slurm for testing, or if you don't want to invest any additional time, I can pick it up from here (but it'll probably be a week or so before I can do that).

@EricR86
Copy link
Copy Markdown
Contributor Author

EricR86 commented Feb 11, 2020

@natefoo sorry for taking so long to get to this but I believe I have created a fix that is now compatible with all versions of SLURM. It's ready for your review and approval.

@holtgrewe
Copy link
Copy Markdown
Contributor

Hi, is there any news on this? I'd really like to get a slurm-drmaa that is compatible with slurm 20.x.

@natefoo
Copy link
Copy Markdown
Owner

natefoo commented Mar 31, 2020

@EricR86 Thanks, this looks good to me. I'll merge and make a new release shortly.

@natefoo natefoo merged commit e3e11b3 into natefoo:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants