SPEC: put Slurm version in RPM release#52
Merged
natefoo merged 1 commit intonatefoo:mainfrom Oct 7, 2021
Merged
Conversation
natefoo
approved these changes
Sep 2, 2021
Owner
natefoo
left a comment
natefoo
left a comment
There was a problem hiding this comment.
I went around in circles when adding the spec trying to figure out the best way to do this. I think this won't force reinstallation when you change Slurm versions but it would at least make it more obvious what's going on to the admin?
Contributor
Author
|
Yes, that won't force reinstallation when the Slurm version is upgraded (and I can't think of a good way to create a dependency that would do this, esp. since only major Slurm versions matter), but that should make things more visible for the admin, that's the idea. |
Owner
|
Thanks @kcgthb! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the Slurm version the RPM has been compiled with in the package name.
The main motivation is to be able to tell from the RPM version which version of Slurm the DRMAA package was built against, and facilitate upgrades when the plugin must be rebuilt for newer Slurm versions.