List type was renamed in 24.05.X, and other minor patches.#86
Merged
natefoo merged 3 commits intonatefoo:mainfrom Oct 9, 2024
sandynomad:patch_24_05
Merged
List type was renamed in 24.05.X, and other minor patches.#86natefoo merged 3 commits intonatefoo:mainfrom sandynomad:patch_24_05
natefoo merged 3 commits intonatefoo:mainfrom
sandynomad:patch_24_05
Conversation
Owner
|
Thanks, this looks great! I'll get the tests fixed up and get this merged. |
'slurm_list_remove' was defined as an extern it wasn't used so remove using conditional for 24.05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 24.05 ListIterator was renamed to list_itr_t
slurm_list_remove was defined as an extern but wasn't used so remove using conditional for 24.05
added // fall through to suppress gcc compiler warnings
fixed fsd_log_error which also caused compiler issues.