Open
Conversation
ripienaar
reviewed
Feb 23, 2026
MauriceVanVeen
force-pushed
the
maurice/feature-flags
branch
from
fba069f to
b0cbf47
Compare
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/feature-flags
branch
from
b0cbf47 to
68ae6c5
Compare
wallyqs
reviewed
Feb 23, 2026
| slices.Sort(value.AllowedOrigins) | ||
| case string, bool, uint8, uint16, uint64, int, int32, int64, time.Duration, float64, nil, LeafNodeOpts, ClusterOpts, *tls.Config, PinnedCertSet, | ||
| *URLAccResolver, *MemAccResolver, *DirAccResolver, *CacheDirAccResolver, Authentication, MQTTOpts, jwt.TagList, | ||
| *OCSPConfig, map[string]string, JSLimitOpts, StoreCipher, *OCSPResponseCacheConfig, *ProxiesConfig, WriteTimeoutPolicy: |
Member
There was a problem hiding this comment.
config reload not supported I think right?
Member
Author
There was a problem hiding this comment.
Correct, it can not be reloaded at the moment (it's intentional and also documented in the ADR)
But this addition was required for reload tests to still function correctly.
wallyqs
pushed a commit
to wallyqs/nats-server
that referenced
this pull request
Feb 23, 2026
Implements the feature flags infrastructure and reload handler identified as missing in the PR nats-io#7866 review. Adds FeatureFlags field to Options, config parsing for feature_flags block, featureFlagsOption reload handler with imposeOrder support, and a reload test covering add/modify/remove. https://claude.ai/code/session_01CVpQg9crJ13QXa73XUcR33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for feature flags to change server behavior in a non-breaking way, as described in ADR-53.
Supporting the new
feature_flagsfield:These are not needed to be used by default. The user can decide whether to opt-in or opt-out of a certain feature if needed. Normally, since no feature flags are used, this will not change anything for a given system. But if they are configured, the server will log about it on server startup:
For example, this shows the user opted-in to new ack/fc JetStream consumer subjects, opted-out of some performance boost (allowing the user to report an issue while remaining on the upgraded version). Additionally, if the user configured the setting equal to the default, a value of
enabledordisabledis shown depending on whether it was enabled or disabled (here the user explicitly defined to not revert a fix in the config). Unsupported fields are still logged, but doesn't prevent server startup, allowing us to add and remove feature flags freely as we see fit (but they'll of course need to be documented).These feature flags are also included in varz, like the
server_tagsandserver_metadata.Related to #7860
Signed-off-by: Maurice van Veen github@mauricevanveen.com