[FIXED] Increment source fails on failed persist, decrement on success#7909
[FIXED] Increment source fails on failed persist, decrement on success#7909MauriceVanVeen wants to merge 1 commit intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8eb3e67b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
MauriceVanVeen
force-pushed
the
maurice/retry-source-persist
branch
from
d8eb3e6 to
1fb9f1c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fb9f1c222
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/retry-source-persist
branch
from
1fb9f1c to
0448cad
Compare
|
Need to add a test.. |
1 participant
If a mirror/source fails to persist a message, it (almost) immediately retries to recreate the mirror/sourcing consumer instead of applying a backoff strategy like one that happens if the consumer create for these would fail.
This PR improves this by applying backoff if persisting for a message repeatedly fails. This PR also relates to #7853, and in that case fixes that the sourcing doesn't hammer on proposals if the Raft layer is being overrun.
Signed-off-by: Maurice van Veen github@mauricevanveen.com