Power-port template with type `dc-terminal` not accepted with API/Ansible

[bsmeding]

Environment

• Nautobot version (Docker tag too if applicable): 1.5.20
• Python version: 3.9.16
• Database platform, version: PostgreSQL : 14
• Middleware(s):

Steps to Reproduce

1. Add power-port template with type: dc-terminal, tried API and Ansible

Expected Behavior

• Adding the power-port to the device template
• With value of dc-terminal as also displayed in GUI

Observed Behavior

Error:

failed: [localhost] (item={'name': 'PS2', 'type': 'dc-terminal'}) => {"ansible_loop_var": "item", "changed": false, "item": {"name": "PS2", "type": "dc-terminal"}, "msg": "value of type must be one of: iec-60320-c6, iec-60320-c8, iec-60320-c14, iec-60320-c16, iec-60320-c20, iec-60309-p-n-e-4h, iec-60309-p-n-e-6h, iec-60309-p-n-e-9h, iec-60309-2p-e-4h, iec-60309-2p-e-6h, iec-60309-2p-e-9h, iec-60309-3p-e-4h, iec-60309-3p-e-6h, iec-60309-3p-e-9h, iec-60309-3p-n-e-4h, iec-60309-3p-n-e-6h, iec-60309-3p-n-e-9h, nema-5-15p, nema-5-20p, nema-5-30p, nema-5-50p, nema-6-15p, nema-6-20p, nema-6-30p, nema-6-50p, nema-l5-15p, nema-l5-20p, nema-l5-30p, nema-l5-50p, nema-l6-20p, nema-l6-30p, nema-l6-50p, nema-l14-20p, nema-l14-30p, nema-l21-20p, nema-l21-30p, cs6361c, cs6365c, cs8165c, cs8265c, cs8365c, cs8465c, ita-e, ita-f, ita-ef, ita-g, ita-h, ita-i, ita-j, ita-k, ita-l, ita-m, ita-n, ita-o, got: dc-terminal"}
...ignoring

When inspecting the form via GUI i see the value dc-terminal
When query a device with this power-template attached, I see DC_TERMINAL as port type.

[glennmatthews]

I see the values in the REST API Swagger schema:

This appears to be a bug in nautobot-ansible, as that module has a hard-coded list of valid values (https://github.com/nautobot/nautobot-ansible/blob/v4.5.0/plugins/modules/power_port.py) that appears not to have been updated to account for the added types from nautobot/nautobot#3413. Similar gaps are likely present in the Ansible module for the other device components (console-port, power-outlet, etc.).

To be honest I'm not sure why the Ansible module should be in the business of enforcing valid choices for this and similar API endpoints; my vote would personally be to remove that logic from the module altogether rather than attempting to keep the list up-to-date with core.

[bsmeding]

Yes indeed now i see the same, i guess the list is in the Ansible module to error out before the connection is made to Nautobot
but not easy to keep those in sync