Merged
Conversation
joewesch
requested review from
a team,
jmcgill298 and
jvanderaa
as code owners
joewesch
force-pushed
the
u/joewesch-update-postgres
branch
from
6cb6576 to
3b65d92
Compare
joewesch
commented
Jan 30, 2026
| if group.get("children"): | ||
| group["children"] = sorted(group["children"]) | ||
| elif group.get("hosts"): | ||
| if group.get("hosts"): |
Contributor
Author
There was a problem hiding this comment.
I'm not sure why this was an elif, but it needed to sort children as well to detect that there were no differences between the fixture and the results.
jvanderaa
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the version of Postgres that we use for tests from 13 to 17.