Feature/vise hendelses id frontend#4259
Merged
Merged
Conversation
…d persons. - Implement HendelseIdPersonMiljoeInfo component for rendering event ID information. - Enhance DollyTooltip to support external tooltip properties. - Update PersonVisning to include HendelseIdPersonMiljoeInfo. - Add useHendelseId hook for fetching event ID data. - Update DollyEndpoints to include endpoint for fetching event IDs. - Modify DataVisning.less for new styles related to event ID display. - Bump version in package.json to 3.5.5.
- Update @typescript-eslint/eslint-plugin and @typescript-eslint/parser to version 8.61.0 - Upgrade electron-to-chromium to version 1.5.369 - Bump side-channel to version 1.1.1 - Update semver to version 7.8.3 #deploy-test-dolly-frontend
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds frontend support for viewing/copying Hendelse-ID (Kafka references) for a person (and related persons) via a new tooltip-based UI, while also extending DollyTooltip to support externally controlled rc-tooltip behavior. In addition, it bumps the app version and updates several JS dependencies (notably @typescript-eslint).
Changes:
- Add new Hendelse-ID data fetching hook + endpoint builder, and render a new Hendelse-ID section in
PersonVisning. - Introduce new tooltip content UI (
HendelseId*components) + styling for category headers/counters and copyable Hendelse-ID. - Extend
DollyTooltipwith optional external-control props forrc-tooltip, and update TypeScript/lockfile dependencies + version.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/dolly-frontend/src/main/js/src/utils/hooks/useHendelseId.tsx | New SWR hook for fetching Hendelse-ID data (optionally for related ident). |
| apps/dolly-frontend/src/main/js/src/service/services/dolly/DollyEndpoints.tsx | Adds hendelseId() endpoint builder used by the new hook/UI. |
| apps/dolly-frontend/src/main/js/src/pages/gruppe/PersonVisning/PersonVisning.tsx | Wires new Hendelse-ID section into the person view and passes related persons. |
| apps/dolly-frontend/src/main/js/src/pages/gruppe/PersonVisning/PersonMiljoeinfo/HendelseIdPersonMiljoeInfo.tsx | New wrapper section (heading + explanatory text) for Hendelse-ID display. |
| apps/dolly-frontend/src/main/js/src/pages/gruppe/PersonVisning/PersonMiljoeinfo/HendelseIdDataVisning.tsx | New tooltip UI to browse grouped events and copy Hendelse-ID values. |
| apps/dolly-frontend/src/main/js/src/pages/gruppe/PersonVisning/PersonMiljoeinfo/DataVisning.less | Adds new styles for Hendelse-ID UI elements (category header, counter, copy row). |
| apps/dolly-frontend/src/main/js/src/components/ui/button/DollyTooltip.tsx | Extends tooltip component to accept external-control props for rc-tooltip. |
| apps/dolly-frontend/src/main/js/pnpm-lock.yaml | Dependency lock updates (typescript-eslint, electron-to-chromium, semver, side-channel, etc.). |
| apps/dolly-frontend/src/main/js/package.json | Bumps version to 3.5.5 and updates @typescript-eslint/* versions. |
Files not reviewed (1)
- apps/dolly-frontend/src/main/js/pnpm-lock.yaml: Language not supported
…eadability. - Enhance styling in DataVisning.less for better layout and error indication. - Add handling for import status messages in HendelseIdDataVisning. - Update TidligereBestillinger to filter out invalid IDs before rendering. - Introduce state management for hover availability in HendelseIdDataVisning. #deploy-test-dolly-frontend
…ering and functionality. - Implement mock responses for various scenarios in HendelseIdDataVisning tests. - Update package dependencies to latest versions for improved stability and features. #deploy-test-dolly-frontend
… phrase and ensure visibility of 'hovedperson'. - Modify test to check for the presence of 'hovedperson' instead of 'Gå til hovedperson'. #deploy-test-dolly-frontend
betsytraran
approved these changes
Jun 17, 2026
betsytraran
left a comment
betsytraran
left a comment
Contributor
There was a problem hiding this comment.
Ser supert ut, bare litt småprik 🤓
- Add warning for duplicate related idents in HendelseIdDataVisning - Change Alert component to StyledAlert for import notification - Refactor related persons handling to ensure uniqueness - Adjust button class for consistent styling #deploy-test-dolly-frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily updates dependencies and improves the flexibility of the
DollyTooltipcomponent. The most significant changes are the upgrade of the@typescript-eslintpackages and related dependencies, minor updates to other dependencies, and enhancements to tooltip customization and UI styling.Dependency Upgrades:
@typescript-eslintrelated packages from version8.60.1to8.61.0in bothpackage.jsonandpnpm-lock.yaml. This includeseslint-plugin,parser,scope-manager,tsconfig-utils,type-utils,utils,visitor-keys,types,typescript-estree, andproject-service. [1] [2] [3] [4] [5]electron-to-chromiumfrom1.5.368to1.5.369,semverfrom7.8.2to7.8.3, andside-channelfrom1.1.0to1.1.1inpnpm-lock.yaml. [1] [2] [3] [4] [5] [6] [7] [8] [9]Component Enhancements:
DollyTooltipcomponent to accept additional props for external tooltip control, such asexternalTrigger,externalMouseEnterDelay,externalMouseLeaveDelay,externalPopupVisible, andexternalOnVisibleChange. This allows for more flexible usage and integration with external tooltip triggers. [1] [2]UI Improvements:
PersonMiljoeinfoview.Other:
3.5.4to3.5.5inpackage.json.