SVCPLAN-3648: register_ping_check - optionally add prefix/suffix or o…#12
Merged
jakerundall merged 1 commit intomainfrom Jul 8, 2025
Conversation
…verride domain name The hostname set in the OS of some cluster nodes corresponds to a private IP that is not pingable by nodes with ping checks based on exported resources. This change allows overriding the default networking.fqdn fact that is normally passed as an exported resource to fix this issue. E.g., allows adding a '-mgmt' suffix to the hostname and forcing an 'internal' domain name.
Contributor
Author
|
Tested on mg with an internal node (mg001) and a "public" node (mgtesthn1). Both nodes would normally register themselves for ping via a hostname that is not pingable by the Puppet server, but now I can override the hostname that is registered with their internal '-mgmt' address, which IS pingable by the Puppet server. |
jakerundall
deleted the
rundall/SVCPLAN-3648/optional_hostname_suffix_for_ping_registration
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…verride domain name
The hostname set in the OS of some cluster nodes corresponds to a private IP that is not pingable by nodes with ping checks based on exported resources.
This change allows overriding the default networking.fqdn fact that is normally passed as an exported resource to fix this issue.
E.g., allows adding a '-mgmt' suffix to the hostname and forcing an 'internal' domain name.