Merged
Conversation
The auth-status tool was returning JSON without authRequired: true, but the UI's isAuthRequired() check requires that field to transition from loading state to auth-required state. Added authRequired: true and message field to auth response. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Tests ensure AuthRequiredResponse format is correct to prevent the "Checking connection..." hang bug from recurring. Tests verify: - authRequired: true is present (the bug was missing this) - All required fields: service, authUrl, state, message - Invalid inputs are rejected - Documents expected response formats Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- xConversations now returns AuthRequiredResponse directly when auth is needed, preventing agent from calling x_auth_status separately - conversation-list UI parses initial data as JSON to detect auth state - UI detects error responses from x_get_conversations and shows auth - Extract handleAuthError helper to reduce cognitive complexity - Move MENTION_PATTERN regex to top level for performance - Fix lint issues (block statements, import order, unused vars) Fixes two issues: 1. Double auth boxes when unauthenticated (both conversation-list and auth-button UIs were showing) 2. "All caught up!" showing before auth prompt when no username set Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
xConversationsnow returnsAuthRequiredResponsedirectly when auth is neededhandleAuthErrorhelper to reduce cognitive complexityMENTION_PATTERNregex to top level for performanceTest plan
🤖 Generated with Claude Code