Fix last_files_match_only to evaluate per file instead of globally#135
Merged
necojackarc merged 1 commit intonecojackarc:masterfrom Apr 2, 2026
Merged
Conversation
Previously, when last_files_match_only was enabled, every time a pattern matched any changed file, all previously accumulated reviewers were cleared. This meant the last pattern that matched ANY file in the PR determined all reviewers, which was wrong when different files had different last-matching patterns. Now, for each changed file independently, we find its last matching pattern's reviewers, then union the results across all files. This correctly handles the case where e.g. a generated file overrides reviewers to [] while a non-generated file in the same directory still matches the wildcard pattern's reviewers.
k0kubun
force-pushed
the
fix-last-files-match-only
branch
from
cea5720 to
0df295a
Compare
k0kubun
added a commit
to ruby/ruby
that referenced
this pull request
Mar 31, 2026
necojackarc/auto-request-review#135 fixes last_files_match_only. Let's use a fork to fix it until it gets merged.
havenwood
pushed a commit
to havenwood/ruby
that referenced
this pull request
Apr 2, 2026
necojackarc/auto-request-review#135 fixes last_files_match_only. Let's use a fork to fix it until it gets merged.
necojackarc
approved these changes
Apr 2, 2026
Owner
necojackarc
left a comment
necojackarc
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the PR 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #80
Previously, when last_files_match_only was enabled, every time a pattern matched any changed file, all previously accumulated reviewers were cleared. This meant the last pattern that matched ANY file in the PR determined all reviewers, which was wrong (different from CODEOWNERS) when different files had different last-matching patterns.
Now, for each changed file independently, we find its last matching pattern's reviewers, then union the results across all files. This correctly handles the case where e.g. a generated file overrides reviewers to [] while a non-generated file in the same directory still matches the wildcard pattern's reviewers.