Feature: uses in composite

[ChristopherHX]

Remove the old hack for composite run steps, use the real runcontext directly.
You can also enable if's in composite, I plan to enable it in https://github.com/ChristopherHX/github-act-runner by default.
If's are now enabled see https://github.com/actions/runner/releases/tag/v2.284.0

Resolves #783
Resolves #926

This change seems to be functional complete.
Multi nested composite needs more Tests, maybe the size will get xl after more tests are added.

[ChristopherHX]

I'm confused,

• the runner doesn't log the exit code of the tests
• Check failure on linux/macOS, doesn't contains FAIL in the log either
• No idea what to try next, is this fail due to the actions/runner???

[ChristopherHX]

Wow removing -v from gotest let it succeed (https://github.com/ChristopherHX/act/runs/3462707672?check_suite_focus=true)
Here the same workflow run with -v https://github.com/ChristopherHX/act/runs/3462703235?check_suite_focus=true and it fails.

Oh maybe remove setup-node from tests will solve this....

[codecov]

Codecov Report

Merging #793 (99b21b3) into master (0f04942) will increase coverage by 7.78%.
The diff coverage is 64.33%.

@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
+ Coverage   49.27%   57.05%   +7.78%     
==========================================
  Files          23       28       +5     
  Lines        2401     4222    +1821     
==========================================
+ Hits         1183     2409    +1226     
- Misses       1090     1605     +515     
- Partials      128      208      +80     

Impacted Files	Coverage Δ
pkg/common/executor.go	46.90% <0.00%> (+2.03%)	⬆️
pkg/common/job_error.go	0.00% <0.00%> (ø)
pkg/common/outbound_ip.go	0.00% <0.00%> (ø)
pkg/common/testflag.go	0.00% <0.00%> (ø)
pkg/container/docker_volume.go	0.00% <0.00%> (ø)
pkg/model/action.go	0.00% <0.00%> (ø)
pkg/container/docker_run.go	5.54% <14.15%> (+3.61%)	⬆️
pkg/common/git.go	49.82% <31.81%> (-9.97%)	⬇️
pkg/runner/logger.go	65.43% <37.50%> (+1.28%)	⬆️
pkg/container/docker_auth.go	45.00% <45.00%> (ø)
... and 35 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef30c3...99b21b3. Read the comment docs.

[jackton1]

@KnisterPeter @catthehacker @ChristopherHX any chance this would be merged soon. I’ll be happy to test the changes.

[ChristopherHX]

@jackton1 You can test snapshots of this PR before it is merged ( I have absolutly no permissions for this repo )

• Press the checks tab of this PR
• select checks on: pull_request on the left panel
• You find a list of artifacts to test
  Direct link of current snapshots of this PR:
  https://github.com/nektos/act/actions/runs/1556315888

I'm awaiting review from cplee, this isn't a small change.

[jackton1]

Okay I’ll test it later today

[jackton1]

@ChristopherHX I can confirm that it works using the snapshot here: https://github.com/nektos/act/actions/runs/1556315888

Only noticed some interpolation errors which could be empty

ERRO[0015] Unable to interpolate string '${{ github.event.pull_request.head.sha }}' - [TypeError: Cannot access member 'head' of undefined] 

FULL LOG OUTPUT

[CI/Test changed-files-1]   ✅  Success - Run changed-files with specific files from a source file using a comma separator
[CI/Test changed-files-1] ⭐  Run Show output
[CI/Test changed-files-1]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /Users/jacktonye/workspace/changed-files/workflow/41.sh] user= workdir=
| {
|   "added_files": "",
|   "all_changed_and_modified_files": "",
|   "all_changed_files": "",
|   "all_modified_files": "",
|   "any_changed": "false",
|   "any_deleted": "false",
|   "any_modified": "false",
|   "copied_files": "",
|   "deleted_files": "",
|   "modified_files": "",
|   "only_changed": "false",
|   "only_deleted": "",
|   "only_modified": "false",
|   "other_changed_files": "README.md",
|   "other_deleted_files": "",
|   "other_modified_files": "README.md",
|   "renamed_files": "",
|   "type_changed_files": "",
|   "unknown_files": "",
|   "unmerged_files": ""
| }
[CI/Test changed-files-1]   ✅  Success - Show output
[CI/Test changed-files-1] ⭐  Run Verify any_changed files comma separator
[CI/Test changed-files-1]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /Users/jacktonye/workspace/changed-files/workflow/42.sh] user= workdir=
[CI/Test changed-files-1]   ✅  Success - Verify any_changed files comma separator
[CI/Test changed-files-1] ⭐  Run Verify any_modified files comma separator
[CI/Test changed-files-1]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /Users/jacktonye/workspace/changed-files/workflow/43.sh] user= workdir=
[CI/Test changed-files-1]   ✅  Success - Verify any_modified files comma separator
[CI/Test changed-files-1] ⭐  Run Verify any_deleted files with comma separator
[CI/Test changed-files-1]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /Users/jacktonye/workspace/changed-files/workflow/44.sh] user= workdir=
[CI/Test changed-files-1]   ✅  Success - Verify any_deleted files with comma separator
ERRO[0015] Unable to interpolate string '${{ github.event.pull_request.head.sha }}' - [TypeError: Cannot access member 'head' of undefined] 
[CI/Test changed-files-1] ⭐  Run Run changed-files with custom sha
ERRO[0015] Unable to interpolate string '${{ github.event.pull_request.head.sha }}' - [TypeError: Cannot access member 'head' of undefined] 

[KnisterPeter]

The interpolation error should be fixed by the new expression evaluator

[cplee]

This is awesome ❤️

[mergify]

@ChristopherHX this pull request has failed checks 🛠

[mergify]

@ChristopherHX this pull request is now in conflict 😩

[mergify]

@ChristopherHX this pull request has failed checks 🛠

[ChristopherHX]

Please help me, what is wrong with superlinter? It just crashs because a file is missing?
https://github.com/nektos/act/runs/4604475831?check_suite_focus=true

I resolved the merge conflict of today.

[catthehacker]

@ChristopherHX it's broken, don't worry about your update

[catthehacker]

https://github.com/github/super-linter/issues/2253

[mergify]

@ChristopherHX this pull request is now in conflict 😩

[catthehacker]

🎉

[davetapley]

@catthehacker any chance of getting a new release with this in? 🙏🏻