Skip to content

ci: build Neovim with MSVC on Windows, matching upstream#616

Merged
justinmk merged 2 commits intomasterfrom
fixci
Apr 10, 2026
Merged

ci: build Neovim with MSVC on Windows, matching upstream#616
justinmk merged 2 commits intomasterfrom
fixci

Conversation

@justinmk
Copy link
Copy Markdown
Member

@justinmk justinmk commented Apr 10, 2026

Problem:

Windows test-upstream build fails:

…/libuv/src/uv-common.c:960:26: warning: passing argument 1 of 'uv__free' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  960 |     uv__free(cpu_infos[i].model);
      |              ~~~~~~~~~~~~^~~~~~
…/libuv/src/uv-common.c:81:21: note: expected 'void *' but argument is of type 'const char *'
   81 | void uv__free(void* ptr) {
      |               ~~~~~~^~~

The test-upstream Windows job builds Neovim with MinGW/GCC via msys2, but Neovim's own CI uses MSVC.

Solution:

Use MSVC/Ninja to build Neovim (matching upstream test_windows.yml), and only use msys2 for running oldtest which requires make.

Problem:
The test-upstream Windows job builds Neovim with MinGW/GCC via msys2,
but Neovim's own CI uses MSVC. libuv triggers a GCC
`-Wincompatible-pointer-types` error.

Solution:
Use MSVC/Ninja to build Neovim (matching upstream `test_windows.yml`),
and only use msys2 for running oldtest which requires make.
@justinmk justinmk merged commit e4b6d6a into master Apr 10, 2026
37 of 44 checks passed
@justinmk justinmk deleted the fixci branch April 10, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant