refactor: replace logs by metrics for memory tracker#2201
Merged
doitian merged 2 commits intoAug 17, 2020
Merged
Conversation
keroro520
previously approved these changes
Aug 4, 2020
chaoticlonghair
force-pushed
the
pr/use-metric-for-memory-tracker
branch
from
8606328 to
38a0d2f
Compare
doitian
reviewed
Aug 11, 2020
Contributor
Author
There was a problem hiding this comment.
The details was collected by metrics service in gather_memory_stats(..).
So we don't have to output them to logs.
doitian
previously approved these changes
Aug 11, 2020
chaoticlonghair
force-pushed
the
pr/use-metric-for-memory-tracker
branch
from
38a0d2f to
14334ea
Compare
Contributor
Author
|
Ready for review! |
doitian
approved these changes
Aug 14, 2020
TheWaWaR
approved these changes
Aug 15, 2020
Contributor
Author
|
bors r=doitian,TheWaWaR |
Contributor
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use metrics to output memory statistics, so we can draw charts in Grafana via prometheus.