Release v0.51.303 — Release JS (stage-p1a — cron toggle + config var expansion + git-discard hardening)

[nesquena-hermes]

Release v0.51.303 — Release JS (stage-p1a)

Three low-risk contributor fixes, each rebased onto fresh master (original branches were 9 commits stale — revert-guard would have rolled back releases on a direct squash). Rebase fidelity verified byte-identical to each PR head; dependencies confirmed present on master.

Fixed

• fix: cron run output toggle — collapse already-open rows instead of re-fetching #3732 (@mysoul12138) — cron run output rows were expand-only; clicking an open row re-fetched pointlessly. Now toggles (collapse + clear state + early return).

Added

• feat(config): expand ${VAR} references in config.yaml at load time #3736 (@Carry00) — WebUI config loader now expands ${VAR} references from os.environ (both load paths); unset vars left as literal ${VAR}.

Security

• [security] fix(git): anchor discard untracked deletes #3702 (@Hinotoi-agent) — git_discard(delete_untracked=true) now deletes untracked files via the anchored helpers (rmtree_anchored/unlink_anchored), closing a validation-to-use symlink-swap window; preserves missing_ok tolerance. Regression tests for both the swap-block and concurrent-missing-file cases.

Gates

• Full suite: 8120 passed, 0 failed (one prior run hit the boot-cascade flake — 448× connection-refused, 0 code errors — cleared on clean re-run)
• Codex regression gate: SAFE TO SHIP (ran [security] fix(git): anchor discard untracked deletes #3702's tests directly: 2 passed)
• Opus correctness gate: SAFE TO SHIP
• ESLint runtime + scope-undef + ruff forward + browser-smoke gates: CLEAN
• Revert-guard: origin/master is ancestor

Closes #3732, closes #3736, closes #3702.

[greptile-apps]

Greptile Summary

This release bundles three independent contributor fixes rebased onto master: a JS toggle fix for cron run rows, environment-variable expansion for the WebUI config loader, and a security hardening of git_discard's untracked-file deletion path to close a validation-to-use symlink-swap window.

• Cron toggle (static/panels.js): _loadRunContent now short-circuits when the target row is already open, clearing expansion state and resetting the arrow button before returning; previously every click re-fetched.
• Env-var expansion (api/config.py): _expand_env_vars is applied to both reload_config and _load_yaml_config_file; ${VAR} in YAML values is replaced with os.environ at load time, with unset vars left as literal strings.
• Anchored deletion (api/workspace_git.py): Untracked-file deletes now go through rmtree_anchored/unlink_anchored, which re-resolve the path at delete time under a dir-fd anchor, blocking a symlink swapped after safe_resolve_ws validation; two regression tests cover the swap-block and concurrent-removal race.

Confidence Score: 4/5

Safe to merge; the security fix is correctly implemented and the other two changes are low-risk.

All three changes are well-scoped. The anchored-deletion fix in workspace_git.py correctly closes the TOCTOU window by re-resolving the path inside the anchored helper at delete time; the missing_ok tolerance for files is preserved while directory deletes intentionally remain strict. The env-var expansion in config.py is applied to both load paths consistently. The JS toggle is a straightforward branch inversion. The only imperfections are a dead null guard in panels.js and a test that relies on an undocumented two-call invariant in _repo_rel — both are cosmetic and do not affect runtime correctness.

tests/test_workspace_git.py — the symlink-swap test's swap trigger depends on _repo_rel making an intermediate safe_resolve_ws call that is not documented in the test itself.

Important Files Changed

Filename	Overview
api/workspace_git.py	Replaces raw shutil.rmtree/Path.unlink with rmtree_anchored/unlink_anchored for untracked file deletion; correctly preserves missing_ok tolerance for files only, closing the validation-to-use symlink-swap window.
api/config.py	Adds _expand_env_vars helper and applies it to both YAML load paths; expansion is values-only, unset vars preserved as literal ${VAR}, logic is correct.
static/panels.js	Adds early-return collapse branch to _loadRunContent; contains one dead null guard (item ?) that is harmless but misleading.
tests/test_workspace_git.py	Adds two regression tests for the anchored-deletion fix; the symlink-swap test's swap trigger relies on an implicit two-call invariant in _repo_rel that is undocumented.
CHANGELOG.md	Changelog entry accurately describes all three changes with correct issue references.

Sequence Diagram

sequenceDiagram
    participant UI as Browser UI
    participant JS as panels.js
    participant API as /api/crons/run

    Note over UI,API: New toggle behaviour
    UI->>JS: click open row
    JS->>JS: item.classList.contains('open') → true
    JS->>JS: remove 'open', clear expansionState, reset button
    JS-->>UI: row collapsed (no API call)

    Note over UI,API: git_discard untracked delete (security fix)
    participant GD as git_discard
    participant SA as safe_resolve_ws
    participant RA as rmtree/unlink_anchored

    GD->>SA: validate path (call 1, via _repo_rel)
    SA-->>GD: resolved target
    GD->>SA: validate path (call 2, pre-delete)
    SA-->>GD: resolved target
    GD->>RA: delete via anchored helper
    RA->>RA: re-resolve at delete time (dir_fd)
    alt symlink swapped after validation
        RA-->>GD: ValueError: Path traversal blocked
    else path still valid
        RA-->>GD: deleted OK
    end

Loading

_{Reviews (1): Last reviewed commit: "docs(changelog): stamp v0.51.303 — Relea..." | Re-trigger Greptile}

[greptile-apps]

Redundant null guard on item

item is guaranteed non-null at this point — item.classList.contains('open') on line 728 would have already thrown a TypeError if item were null. The ternary item ? item.querySelector(…) : null is dead code that adds noise without any safety benefit.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[greptile-apps]

Swap trigger relies on _repo_rel calling safe_resolve_ws as call #1

The test comment ("validates once for the Git pathspec and once immediately before deletion") is accurate — _repo_rel internally calls safe_resolve_ws(ctx.workspace, workspace_rel) before the explicit call at the deletion site — but this coupling is invisible in the test. If a future refactor inlines _repo_rel without that intermediate safe_resolve_ws call, state["calls"] would never reach 2, the swap would never trigger, and the test would fail on assert state["swapped"] is True rather than surfacing the regression in the production code. Adding a comment or an explicit assertion like assert state["calls"] >= 2 would make the precondition explicit and guard against silent drift.