fix!: use eslint-plugin-n instead of eslint-plugin-node#482
Merged
kodiakhq[bot] merged 1 commit intomainfrom Apr 1, 2022
Merged
fix!: use eslint-plugin-n instead of eslint-plugin-node#482kodiakhq[bot] merged 1 commit intomainfrom
eslint-plugin-n instead of eslint-plugin-node#482kodiakhq[bot] merged 1 commit intomainfrom
Conversation
ehmicky
added
the
type: chore
erezrokah
approved these changes
Apr 1, 2022
Contributor
erezrokah
left a comment
erezrokah
left a comment
There was a problem hiding this comment.
I'm assuming this is breaking change for this library if we need to rename rules in consumers?
Can we merge with fix!: ...?
ehmicky
force-pushed
the
fix/eslint-plugin-n
branch
from
0e66f3c to
d0cb9a5
Compare
Contributor
Author
|
Right, great call @erezrokah! |
ehmicky
changed the title
eslint-plugin-n instead of eslint-plugin-nodeeslint-plugin-n instead of eslint-plugin-node
ehmicky
added
automerge
and removed
type: bug
Contributor
|
This was a breaking change, but not in the way we expected? https://github.com/netlify/cli/runs/5791278004?check_suite_focus=true#step:7:17 |
Contributor
Author
|
Re-building |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #321 (comment)
eslint-plugin-nodeis unmaintained andeslint-plugin-nis a maintained fork.This will allow us to upgrade to ESLint v8.
Checklist
Please add a
xinside each checkbox: