clean direct buffer#150
Merged
stevehu merged 2 commits intonetworknt:masterfrom Dec 12, 2024
kuibot:master
Merged
Conversation
Contributor
|
@atmoshaman Thanks a lot for the PR. I am trying to search other places direct buffers are used. |
Contributor
|
I was trying to figure out if any other places need to be updated but never got a chance. Merged it first to resolve the current issue. Thanks a lot for your help. |
stevehu
added a commit
that referenced
this pull request
Dec 26, 2024
Contributor
|
I have to roll back the change as the request to the service will freeze forever. Do you know the root cause? |
Contributor
Author
|
Sorry, The original code used IoCallback to deallocate DirectByteBuffer, The buffer could be freed while Undertow was still sending data, This premature deallocation caused the request to freeze. |
Contributor
|
OK. I understand now. Let's closely monitor the current code for while. Thanks. |
Contributor
Author
#156 please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clean direct buffer @stevehu