Add destination_name attr to all MessageTransactions#1425
Merged
TimPansino merged 3 commits intomainfrom Jul 17, 2025
Merged
Conversation
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 6 | 0 | 0 | 0.69s | |
| markdownlint | 7 | 0 | 1 | 0 | 1.11s | |
| ✅ MARKDOWN | markdown-link-check | 7 | 0 | 0 | 20.7s | |
| ✅ PYTHON | ruff | 916 | 0 | 0 | 0 | 0.86s |
| ✅ PYTHON | ruff-format | 916 | 0 | 0 | 0 | 0.26s |
| ✅ YAML | prettier | 13 | 0 | 0 | 0 | 1.12s |
| ✅ YAML | v8r | 13 | 0 | 0 | 6.32s | |
| ✅ YAML | yamllint | 13 | 0 | 0 | 0.59s |
See detailed report in MegaLinter reports
mergify
Bot
added
tests-failing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1425 +/- ##
=======================================
Coverage 81.33% 81.33%
=======================================
Files 207 207
Lines 23466 23466
Branches 3710 3710
=======================================
+ Hits 19085 19087 +2
+ Misses 3123 3121 -2
Partials 1258 1258 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TimPansino
approved these changes
Jul 17, 2025
|
Thank you for fixing this! When we can expect this to be released? |
Contributor
Expecting to release this tomorrow (Thursday). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix a bug in messagebroker instrumentations where the serialize methods were looking for the
destination_nameattribute on the MessageTransaction and it did not exist.Related Github Issue
Fixes #1363 and #1045.