[stable8] fix(NcCheckboxRadioSwitch): use reactive state for group checkbox toggle#8355
Merged
pringelmann merged 3 commits intostable8from Apr 10, 2026
Merged
[stable8] fix(NcCheckboxRadioSwitch): use reactive state for group checkbox toggle#8355pringelmann merged 3 commits intostable8from
pringelmann merged 3 commits intostable8from
Conversation
backportbot
Bot
added
bug
skjnldsv
approved these changes
Mar 25, 2026
pringelmann
force-pushed
the
backport/8324/stable8
branch
from
12ad3aa to
85b1f6d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable8 #8355 +/- ##
===========================================
+ Coverage 45.85% 45.99% +0.14%
===========================================
Files 194 194
Lines 4892 4890 -2
Branches 1262 1200 -62
===========================================
+ Hits 2243 2249 +6
+ Misses 2561 2555 -6
+ Partials 88 86 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pringelmann
force-pushed
the
backport/8324/stable8
branch
from
845af29 to
d8e77d2
Compare
The array/group checkbox path in onToggle read input.checked from the DOM via getInputsSet(). On keyboard spacebar, the browser toggles input.checked before firing the change event, so the DOM-read logic inverted the intended action and emitted the stale modelValue. Replace DOM queries with reactive-state reads (this.isChecked and this.internalModelValue) which correctly reflect the pre-toggle state regardless of the event source. Fixes #8321 Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
stable8 uses Vue Test Utils v1 which requires propsData instead of props and wrapper.destroy() instead of wrapper.unmount(). Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
force-pushed
the
backport/8324/stable8
branch
from
d8e77d2 to
23befe9
Compare
Contributor
susnux
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #8324