Skip to content

ci(dependabot): bring back Nextcloud command approve#8462

Merged
ShGKme merged 1 commit intomainfrom
ci/dependabot-nextcloud-command-approve
Apr 23, 2026
Merged

ci(dependabot): bring back Nextcloud command approve#8462
ShGKme merged 1 commit intomainfrom
ci/dependabot-nextcloud-command-approve

Conversation

@ShGKme
Copy link
Copy Markdown
Contributor

@ShGKme ShGKme commented Apr 23, 2026

☑️ Resolves

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme requested review from Antreesy, GVodyanov and susnux April 23, 2026 07:10
@ShGKme ShGKme self-assigned this Apr 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.41%. Comparing base (31cb207) to head (6d27fd3).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8462   +/-   ##
=======================================
  Coverage   54.41%   54.41%           
=======================================
  Files         104      104           
  Lines        3398     3398           
  Branches      993      992    -1     
=======================================
  Hits         1849     1849           
  Misses       1309     1309           
  Partials      240      240           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +53 to +58
# Nextcloud bot approve
- name: Nextcloud Bot approve
uses: hmarr/auto-approve-action@f0939ea97e9205ef24d872e76833fa908a770363 # v4.0.0
if: startsWith(steps.branchname.outputs.branch, 'dependabot/')
with:
github-token: ${{ secrets.DEPENDABOT_AUTOMERGE_TOKEN }}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then this should be part of the templates.
It is not - I guess its replaced with the bot approval directly above this?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Library requires two approvals, maybe that was the reason for duplication?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes this one requires two (most only one).
Not sure when it got removed but its in upstream templates, so should also be added back to library templates:

nextcloud-libraries/.github#150

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need it in a template, if this is only needed in this repo?

@ShGKme ShGKme merged commit 2e3ba39 into main Apr 23, 2026
27 checks passed
@ShGKme ShGKme deleted the ci/dependabot-nextcloud-command-approve branch April 23, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants