Due date notification setting per board

[juliusknorr]

• Resolves: Ability to choose to be notified per board #713
• Target version: master

Summary

• Implement a notification setting per board that allows to adjust if due date notifications should be sent
  • for all cards
  • only for assigned cards default
  • never

The user interface was slightly adjusted since having all those settings in the main menu feels to clutter a lot already, so in contrast to Talk where the options are shown directly this is now hidden in a submenu:

TODO

• Proper icons instead of radio buttons
• Update API documentation for new config endpoints and extended board result
• Check with @jancborchardt if we should make "all cards" the default for boards that are not shared yet
• Cover assignement notification handling with tests

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Documentation (manuals or wiki) has been updated or is not required

[nickvergessen]

See comments

[ChristophWurst]

Code looks clean

[juliusknorr]

Quick update on the icons to align with talk:

[jancborchardt]

Very nice with the submenu! :) Is that a component already which could be used elsewhere?

Generally it’s super nice already, here’s some possibility for enhancement, your call if or when it gets done. :D

• For proper feedback: A subline for the "Due date reminders" entry with the chosen setting (like you know from Android and iOS) because otherwise you have to go into the submenu to know the active setting. The icon could also reflect the chosen setting.
• Nice to have: A quick animation left/right when the submenu gets shown and when you go back.
• This is more generally about the ActionMenu component (cause this is also the case for Talk), but the hover/focus and active style needs to be adjusted to move from the blue bar & text opacity towards just changing the background. cc @ma12-co

[jancborchardt]

Check with @jancborchardt if we should make "all cards" the default for boards that are not shared yet

Yeah, good question. Cause then would it switch to "Assigned cards" when you share it?

[juliusknorr]

Yeah, good question. Cause then would it switch to "Assigned cards" when you share it?

Yes, we could of course just hide the assigned setting if a board is not shared and just offer on/off then. Of course this will need some careful handling of adjusting the setting if all shares get removed from a board.

[jancborchardt]

Yes, we could of course just hide the assigned setting if a board is not shared and just offer on/off then. Of course this will need some careful handling of adjusting the setting if all shares get removed from a board.

Right, then for a non-shared board it could just be a checkbox for "Due date notifications" without the need for a submenu.
Then the switch to a submenu with a "different" default setting wouldn’t be so strange, cause it’s more clear there’s a difference.

[juliusknorr]

@jancborchardt I'll leave the animation for a later point in time, other comments in scope of the deck app should be addressed

[stefan-niedermann]

@juliushaertl don't want to nag, but did you think about REST-API documentation (if this feature will also be available in the API)? 😇

[juliusknorr]

@stefan-niedermann I already thought about you ❤️

b18ebe8

Resolved