Skip to content

Only try to extract first part of the explode result #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 1 commit into from
Nov 12, 2020
Merged

Only try to extract first part of the explode result #2524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Service/ConfigService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public function getAll(): array {

public function get($key) {
$result = null;
[$scope, $id] = explode(':', $key, 2);
[$scope] = explode(':', $key, 2);
Copy link
Copy Markdown
Member

@ChristophWurst ChristophWurst Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[$scope] = explode(':', $key, 2);
[$scope] = explode(':', $key, 1);

if you don't care about the rest :)

Copy link
Copy Markdown
Member Author

@juliusknorr juliusknorr Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that would basically not explode the value at all:

If limit is set and positive, the returned array will contain a maximum of limit elements with the last element containing the rest of string.

$foo = explode(':', 'a:b:c:d', 1);
array(1) {
  [0]=>
  string(7) "a:b:c:d"
}

switch ($scope) {
case 'groupLimit':
if (!$this->groupManager->isAdmin($this->userId)) {
Expand Down
⚡