Skip to content

Upcoming/Today/Tomorrow dashboard widgets#2658

Merged
juliusknorr merged 6 commits intonextcloud:mainfrom
BKapelari:More-Dashboard-Widgets-#2643
Oct 18, 2023
Merged

Upcoming/Today/Tomorrow dashboard widgets#2658
juliusknorr merged 6 commits intonextcloud:mainfrom
BKapelari:More-Dashboard-Widgets-#2643

Conversation

@BKapelari
Copy link
Copy Markdown
Contributor

@BKapelari BKapelari commented Dec 16, 2020 •
edited
Loading

Summary

Basic function for the new dashboard widgets

TODO

  • Translations

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

juliusknorr
juliusknorr reviewed Dec 16, 2020
View reviewed changes
Comment thread l10n/de_DE.js Outdated
juliusknorr
juliusknorr reviewed Dec 16, 2020
View reviewed changes
Comment thread lib/Dashboard/DeckWidgetToday.php Outdated
juliusknorr
juliusknorr reviewed Dec 17, 2020
View reviewed changes
Comment thread src/views/DashboardToday.vue Outdated
juliusknorr
juliusknorr reviewed Dec 17, 2020
View reviewed changes
Comment thread src/views/DashboardToday.vue Outdated
Copy link
Copy Markdown
Member

@juliusknorr juliusknorr Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those could go into a mixin to avoid duplicate code across widgets.

Copy link
Copy Markdown
Contributor Author

@BKapelari BKapelari Jan 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still open

Copy link
Copy Markdown
Member

@marcelklehr marcelklehr Oct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's how you create a mixin: https://v2.vuejs.org/v2/guide/mixins.html

Let me know if you need help :)

juliusknorr
juliusknorr reviewed Dec 17, 2020
View reviewed changes
Comment thread src/views/DashboardToday.vue Outdated
@BKapelari
Copy link
Copy Markdown
Contributor Author

BKapelari commented Dec 17, 2020 •
edited
Loading

Idea: Should we rename src/views/Dashboard.vue to something else?

@juliusknorr
Copy link
Copy Markdown
Member

juliusknorr commented Dec 18, 2020

Idea: Should we rename src/views/Dashboard.vue to something else?

Yes, since this PR introduces DashboardToday and DashboardTomorrow, it could just be DashboardUpcoming for example.

@BKapelari
Copy link
Copy Markdown
Contributor Author

BKapelari commented Jan 4, 2021

@juliushaertl please take a look.

juliusknorr
juliusknorr reviewed Jan 5, 2021
View reviewed changes
Comment thread lib/Dashboard/DeckWidgetUpcoming.php Outdated
@BKapelari
Copy link
Copy Markdown
Contributor Author

BKapelari commented Jan 15, 2021

@juliushaertl do you think, we can let this on this status an merge it into main?
If you see any problems, let me know, I will try to resolve them

@juliusknorr juliusknorr added this to the 1.3.0 milestone Jan 28, 2021
@juliusknorr
Copy link
Copy Markdown
Member

juliusknorr commented Jan 28, 2021

Sorry for the delay here, I have it on my list of things to review.

@BKapelari
Copy link
Copy Markdown
Contributor Author

BKapelari commented Feb 8, 2021 •
edited
Loading

can we merge? Are only a few changes: https://github.com/nextcloud/deck/pull/2658/files

@juliusknorr juliusknorr modified the milestones: 1.3.0, 1.4.0, 1.5.0, 2.0.0 Apr 7, 2021
@jakobroehrl
Copy link
Copy Markdown
Contributor

jakobroehrl commented Oct 29, 2021

@BKapelari could you provide some screenshots?

@juliusknorr juliusknorr modified the milestones: 1.5.0, 1.6.0 Nov 5, 2021
@juliusknorr juliusknorr modified the milestones: 1.6.0, 1.7.0 Dec 30, 2021
@juliusknorr juliusknorr changed the title basic functions Upcoming/Today/Tomorrow dashboard widgets Aug 9, 2022
@marcelklehr
Copy link
Copy Markdown
Member

marcelklehr commented Jan 6, 2023

I gave this some love and resolved all open issues. Should be good to go now.

image

@juliusknorr juliusknorr self-requested a review January 6, 2023 18:05
BKapelari and others added 4 commits October 18, 2023 11:44
@BKapelari @juliusknorr
basic functions
7b57c92 
Signed-off-by: Bernhard Kapelari <bernhard@kapelari.com>

First feedback

Signed-off-by: Bernhard Kapelari <bernhard@kapelari.com>

lint:fix

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr @juliusknorr
Dashboard widgets: Factor out a card component
515d9cb 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr @juliusknorr
Vuex: Run overview#loadUpcoming only once
a37e719 
needed for dashboard widgets

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr @juliusknorr
Rename today and tomorrow widgets
6aaa9be 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@juliusknorr
Copy link
Copy Markdown
Member

juliusknorr commented Oct 18, 2023

Did another rebase and resolved conflicts

@juliusknorr
fix: Switch to new component name
0b68948 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
style: Fix stylelint
7c774bd 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr merged commit ea67956 into nextcloud:main Oct 18, 2023
@marcelklehr
Copy link
Copy Markdown
Member

marcelklehr commented Oct 18, 2023

🎉

@BKapelari BKapelari deleted the More-Dashboard-Widgets-#2643 branch October 18, 2023 16:40
@qualitaetsdefensive
Copy link
Copy Markdown

qualitaetsdefensive commented Jul 18, 2024

Hi, I want to add the Upcoming cards widget to the dashboard for all the users of my nextcloud via occ command like so:

<occ config:app:set dashboard layout --value='welcome,mail,activity,UpcomingCards'>

I am however unsure about the parameter I need to pass to this command to add the mentioned widget. I looked around the repo with search funtion but as I am no javascript nor php programmer I was not able to find what I was looking for.
Any help or documentation is much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehr marcelklehr marcelklehr left review comments

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

No one assigned

Labels

4. to release enhancement

Projects

📝 Productivity team
Archived in project

Milestone

1.10.0 (Nextcloud 27)

Development

Successfully merging this pull request may close these issues.

More Dashboard Widgets

5 participants

@BKapelari @juliusknorr @jakobroehrl @marcelklehr @qualitaetsdefensive
⚡