Generate fixed link for activity emails#3611
Merged
luka-nextcloud merged 1 commit intomasterfrom Mar 9, 2022
Merged
Conversation
juliusknorr
requested changes
Feb 28, 2022
juliusknorr
reviewed
Mar 3, 2022
Comment on lines
+69
to
+70
| $this->cardMapper = $cardMapper; | ||
| $this->urlGenerator = $urlGenerator; |
Member
There was a problem hiding this comment.
Those are not needed anymore now, as the url generation has been moved to the CardService 😉
juliusknorr
reviewed
Mar 3, 2022
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Tested and works 👍
@luka-nextcloud Can you have a look at the one comment in regards to the unused code and make sure that the tests pass?
Member
|
Seems the tests were somehow failing due to a server change in the TestCase class, I've moved that over to the phpunit one, so we can get this in, but likely something that might occur elsewhere as well |
juliusknorr
force-pushed
the
bug/generate-fixed-link-for-activity-emails
branch
2 times, most recently
from
ed7d8c8 to
a24c77e
Compare
Signed-off-by: Luka Trovic <luka@nextcloud.com> fix: generate fixed link for activity emails Signed-off-by: Luka Trovic <luka@nextcloud.com> Fix tests Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bug/generate-fixed-link-for-activity-emails
branch
from
a24c77e to
165375f
Compare
juliusknorr
approved these changes
Mar 9, 2022
Member
|
/backport to stable23 |
Member
|
/backport to stable22 |
delete-merged-branch
Bot
deleted the
bug/generate-fixed-link-for-activity-emails
branch
This was referenced Mar 9, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luka Trovic luka@nextcloud.com
Summary
TODO
Checklist