Skip to content

Cleaning up unused indicies#5612

Merged
juliusknorr merged 2 commits intonextcloud:mainfrom
mintsoft:index_cleanup
May 9, 2024
Merged

Cleaning up unused indicies#5612
juliusknorr merged 2 commits intonextcloud:mainfrom
mintsoft:index_cleanup

Conversation

@mintsoft
Copy link
Copy Markdown

@mintsoft mintsoft commented Feb 22, 2024

Summary

Adding migration to cleanup these unused indicies; I have absolutely no idea what is going on with the naming convention on the filename/class so I've made something up.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@mintsoft mintsoft changed the title Cleaning up unused indicies, fixes #5520 Cleaning up unused indicies Feb 22, 2024
Copy link
Copy Markdown
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I left two small comments, maybe you can adjust that.

In addition please also comment out the index creation in the original migrations so that on new installations we do not need to run those.

Comment thread lib/Migration/Version11000Date20240222115515.php Outdated
Comment thread lib/Migration/Version11000Date20240222115515.php Outdated
@mintsoft
Copy link
Copy Markdown
Author

All done

@mintsoft mintsoft requested a review from juliusknorr March 8, 2024 16:25
@mintsoft
Copy link
Copy Markdown
Author

mintsoft commented May 2, 2024

@juliushaertl polite reminder about this PR, I've just rebased and such so it's ready

Signed-off-by: Rob Emery <git@mintsoft.net>
… made for performance and removing the original

creation of the indicies for new installations

Signed-off-by: Rob Emery <git@mintsoft.net>
@juliusknorr juliusknorr merged commit 1f20554 into nextcloud:main May 9, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redundant database indices

2 participants