Skip to content

feat: Implement a team resource provider#5625

Merged
mejo- merged 2 commits intomainfrom
feat/team-provider
Mar 6, 2024
Merged

feat: Implement a team resource provider#5625
mejo- merged 2 commits intomainfrom
feat/team-provider

Conversation

@juliusknorr
Copy link
Copy Markdown
Member

@juliusknorr juliusknorr commented Feb 27, 2024

Implement a team resource provider for nextcloud/server#42433

Copy link
Copy Markdown
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well after the proposed change. CI found some formatting fixes that would need to be applied for making CI green.

Comment thread lib/Teams/DeckTeamResourceProvider.php Outdated
Comment thread tests/integration/config/behat.yml
Copy link
Copy Markdown
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch meant to request changes, not approve 🙈

@juliusknorr juliusknorr marked this pull request as ready for review March 5, 2024 19:12
@juliusknorr juliusknorr requested a review from mejo- March 5, 2024 19:12
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr mentioned this pull request Mar 5, 2024
28 tasks
@mejo- mejo- merged commit 044706f into main Mar 6, 2024
@delete-merged-branch delete-merged-branch Bot deleted the feat/team-provider branch March 6, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants