Skip to content

fix: close modal after deleting card#6617

Merged
grnd-alt merged 1 commit intonextcloud:mainfrom
ludij:fix/6263-close-modal-after-card-delete
Dec 19, 2024
Merged

fix: close modal after deleting card#6617
grnd-alt merged 1 commit intonextcloud:mainfrom
ludij:fix/6263-close-modal-after-card-delete

Conversation

@ludij
Copy link
Copy Markdown
Contributor

@ludij ludij commented Dec 19, 2024

Summary

When a card is opened in the modal or sidebar and then deleted, the router now goes to the board, so that the modal closes. The sidebar was already closing, but incorrectly kept the URL for the card.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Luutzen Dijkstra <luutzen.dijkstra@gmail.com>
Copy link
Copy Markdown
Member

@grnd-alt grnd-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Congratulations on your first contribution

@grnd-alt
Copy link
Copy Markdown
Member

/backport to stable28

@grnd-alt
Copy link
Copy Markdown
Member

/backport to stable29

@grnd-alt
Copy link
Copy Markdown
Member

/backport to stable30

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 2, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants