Skip to content

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti…#6623

Merged
juliusknorr merged 1 commit intomainfrom
bugfix/noid/notification-handling
Dec 30, 2024
Merged

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti…#6623
juliusknorr merged 1 commit intomainfrom
bugfix/noid/notification-handling

Conversation

@nickvergessen
Copy link
Copy Markdown
Member

…on which is deprecated

If a user has any notifications this log is generated all the time:

OCA\Deck\Notification\Notifier::prepare() threw \InvalidArgumentException which is deprecated. Throw \OCP\Notification\UnknownNotificationException when the notification is not known to your notifier and otherwise handle all \InvalidArgumentException yourself

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

…on which is deprecated

Signed-off-by: Joas Schilling <coding@schilljs.com>
@juliusknorr juliusknorr merged commit 989db86 into main Dec 30, 2024
@juliusknorr juliusknorr deleted the bugfix/noid/notification-handling branch December 30, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants