feat: add ability to customize API root path in service URL#143
feat: add ability to customize API root path in service URL#143
Conversation
| </NcTextField> | ||
| <NcButton type="tertiary" | ||
| :title="t('integration_openai', 'Leave empty to use {openaiApiUrl}', { openaiApiUrl: 'https://api.openai.com' })"> | ||
| :title="t('integration_openai', 'Leave empty to use {openaiApiUrl}', { openaiApiUrl: 'https://api.openai.com/v1' })"> |
There was a problem hiding this comment.
let's add v1 to line 15 too
| {{ t('integration_openai', 'This should include the address of your LocalAI instance (or any service implementing an API similar to OpenAI) along with the root path of the API. This URL will be accessed by your Nextcloud server.') }} | ||
| </p> | ||
| <p> | ||
| {{ t('integration_openai', 'This can be a local address with a port like {example}. In this case make sure \'allow_local_remote_servers\' is set to true in config.php', { example : 'http://localhost:8080' }) }} |
There was a problem hiding this comment.
same here, v1 should be appended to the url
|
Adding a preview like a computed URL for an example endpoint like chat completions |
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
I agree with the review from @kyteinsky . Appart from that, all good.
For appconfig values, using IAppConfig in the migration step was the right thing to do 👍
Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
edward-ly
force-pushed
the
feat/api-path
branch
from
886f571 to
e75bd0b
Compare
|
Done. I decided to use another NcNoteCard to display the preview as I thought NcTextField's helperText in dark mode was too faint to be usable, but I am open to other ideas. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
3 participants
Resolves #105.