Make image generation work with base64 responses (e.g. IONOS)#177
Make image generation work with base64 responses (e.g. IONOS)#177
Conversation
…e64 responses Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
| $output['images'][] = $imageResponse->getBody(); | ||
| } | ||
| foreach ($b64s as $b64) { | ||
| if ($b64 !== null) { |
There was a problem hiding this comment.
null is already filtered above, this list should be all strings
|
Let's add an option for choosing the response type in the admin settings in image gen section for api endpoints other than official openai. Or even wtih official openai. |
For what should we add this? The image you get in the frontend should not differ depending on response type, so I think there is no difference for the user. And that would be one more chance to disconfigure the integration so it doesn't work, if we always just check for both it's failproof, wdyt? |
|
I agree with @janepie, making it work automagically is superior to adding an option, I think. |
|
Yeah that part is perfect. Issues might be with the API and it might return empty responses for If there is proof of the contrary for popular local providers, this is good as is. |
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
|
We could delete it and just always use the default? |
|
Yeah we can probably assume (and hope) that the So I would be in favour of removing this param from the request. |
|
yeah let's do that 🚀 |
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
4 participants
No description provided.