feat(settings): add shared Office admin section#60285
Open
joshtrichards wants to merge 4 commits intomasterfrom
Open
feat(settings): add shared Office admin section#60285joshtrichards wants to merge 4 commits intomasterfrom
joshtrichards wants to merge 4 commits intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changeset introduces a new shared Office admin settings section. It adds a canonical
IIconSectionforofficeso office-related apps can register their settings under a single umbrella section instead of each shipping their own separate section.Encourages apps to stop defining app-specific section implementations and register their settings under
officeinstead, similar togroupware,connected-apps, etc.For example, if one has
richdocuments+richdocumentscodeinstalled, both register their own sections. This is confusing to the end-user since it adds to the "noise" at the top-level of the admin settings sections list plus they're both part of the overall "Office" setup (and the latter has very little contained in it anyhow).Existing apps do not have to transition (but they should IMO) so there's no compatible problem introduced.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)