fix(code): fix regex to not eat preceding character#8540
Open
Conversation
Fixes: #5483 This bug got introduced in upstream Tiptap with ueberdosis/tiptap#5916, which removes named capturing groups and lookbehind assertions from the regex in order to fix support for Safari < 16.4. Upstream issue ueberdosis/tiptap#6358 tracks this bug a ping some months back whether it would be an option to revert this change nowadays didn't get any reply. So let's overwrite the regexes on our side. Signed-off-by: Jonas <jonas@freesources.org>
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mejo-
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
Member
Author
|
/backport to stable33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5483
This bug got introduced in upstream Tiptap with ueberdosis/tiptap#5916, which removes named capturing groups and lookbehind assertions from the regex in order to fix support for Safari < 16.4.
Upstream issue ueberdosis/tiptap#6358 tracks this bug a ping some months back whether it would be an option to revert this change nowadays didn't get any reply.
So let's overwrite the regexes on our side.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)