Skip to content

[nextest-runner] read build script env vars from structured Cargo data#3168

Merged
sunshowers merged 1 commit into
mainfrom
env-structured
Mar 16, 2026
Merged

[nextest-runner] read build script env vars from structured Cargo data#3168
sunshowers merged 1 commit into
mainfrom
env-structured

Conversation

@sunshowers

@sunshowers sunshowers commented Mar 16, 2026

Copy link
Copy Markdown
Member

Part 1 of fixes for #3167. Don't depend on Cargo internals since a stable interface is available.

We no longer archive the output file, so this breaks new archives + old nextest, but that should be okay: in general I'd expect old archive + new nextest to work better.

Don't depend on Cargo internals since a stable interface is available.

We no longer archive the output file, so this breaks new archives + old
nextest, but that should be okay: in general I'd expect old archive + new
nextest to work better.
@codecov

codecov Bot commented Mar 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.59259% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.19%. Comparing base (790bd81) to head (a730ece).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nextest-runner/src/test_command.rs 70.00% 3 Missing ⚠️
nextest-runner/src/list/binary_list.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3168      +/-   ##
==========================================
- Coverage   85.20%   85.19%   -0.02%     
==========================================
  Files         158      158              
  Lines       46366    46399      +33     
==========================================
+ Hits        39508    39528      +20     
- Misses       6858     6871      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sunshowers sunshowers merged commit d9c9241 into main Mar 16, 2026
21 checks passed
@sunshowers sunshowers deleted the env-structured branch March 17, 2026 00:02
@trunk-io

trunk-io Bot commented Mar 17, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant