[nextest-runner] fix slow test display with --status-level fail#3236
Merged
Conversation
Previously we would display lines like: ``` [> 60.000s] (─────────) omicron-nexus app::sagas::snapshot_create::test::test_action_failure_can_unwind_no_pantry [> 60.000s] (─────────) oximeter-db client::tests::test_replicated ``` where the status (SLOW) isn't displayed but the test name and durations are. That is definitely buggy. Fix and add tests. This can be reproduced with: ``` cargo nextest replay -R =(curl -L https://buildomat.eng.oxide.computer/wg/0/artefact/01KN02PY451PZYF3H5FKR99G7E/XhPWJ5Y9hYidiHof0Dg3hH5QhN8cFsRzzXmBAc4JNSX0EIKi/01KN02Q95YCQ9SY3V907RCXCXB/01KN0459SV6Y6EDAZ962QEQ3ZX/nextest-run-archive.zip) --status-level fail ```
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3236 +/- ##
==========================================
+ Coverage 85.37% 85.44% +0.06%
==========================================
Files 159 159
Lines 47063 47202 +139
==========================================
+ Hits 40182 40333 +151
+ Misses 6881 6869 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we would display lines like:
where the status (SLOW) isn't displayed but the test name and durations are. That is definitely buggy.
Fix and add tests. This can be reproduced with: