Improve runner parsing#75
Merged
Merged
Conversation
sunshowers
reviewed
Feb 23, 2022
sunshowers
left a comment
sunshowers
left a comment
Member
There was a problem hiding this comment.
Looks good, just one change required.
sunshowers
reviewed
Feb 23, 2022
Member
|
I'm going to get a quick hotfix out to make nextest non-fatal in case of any issues (which I believe is the correct thing to do anyway), then let's figure out a good fix here. |
Guiguiprim
force-pushed
the
improve-runner-parsing
branch
2 times, most recently
from
294e674 to
9ed4789
Compare
sunshowers
reviewed
Feb 23, 2022
Guiguiprim
force-pushed
the
improve-runner-parsing
branch
from
9ed4789 to
da627c4
Compare
sunshowers
reviewed
Feb 23, 2022
Guiguiprim
force-pushed
the
improve-runner-parsing
branch
from
da627c4 to
bc78721
Compare
Member
|
I'll have a final look at this and land it later today. Thanks! |
Member
|
Thanks! I have some minor plans for improvement but I'll land this and iterate on it myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #73
I'm not sure about the second commit. Maybe we should stop the ancestors walk at the workspace root ?
What was the goal behind
use_cargo_home? tests ? If so, I guess both approach would work.Fun fact: the tests where broken before the first commit on my computer because they were reading my home config with an array of strings (even with the
use_cargo_home = false)...