Skip to content

Improve secrets rendering#4840

Merged
pditommaso merged 7 commits intomasterfrom
3502-use-secrets-with-include-config-v2
Mar 22, 2024
Merged

Improve secrets rendering#4840
pditommaso merged 7 commits intomasterfrom
3502-use-secrets-with-include-config-v2

Conversation

@pditommaso
Copy link
Copy Markdown
Member

@pditommaso pditommaso commented Mar 22, 2024 •
edited
Loading

This PR simplifies the rendering of secrets in the the nextflow config using a AST transformation instead of using the SecretContext class.

See also #4177

@pditommaso pditommaso requested a review from bentsherman March 22, 2024 00:41
@pditommaso
Fix missing classes
0ad3a00 
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso
Improve config + fix issue with closures
18b5133 
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso
Copy link
Copy Markdown
Member Author

pditommaso commented Mar 22, 2024

Should be OK, now.

@bentsherman
Copy link
Copy Markdown
Member

bentsherman commented Mar 22, 2024

Code looks good. Did you do a manual end-to-end test?

@bentsherman bentsherman mentioned this pull request Mar 22, 2024
Closed
@pditommaso
Copy link
Copy Markdown
Member Author

pditommaso commented Mar 22, 2024

Some basic command, you may want to double check it

@bentsherman bentsherman linked an issue Mar 22, 2024 that may be closed by this pull request
Unable to use secrets in the includeConfig directive #3502
Closed
bentsherman
bentsherman approved these changes Mar 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@bentsherman bentsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual test passed 👍

@pditommaso
Copy link
Copy Markdown
Member Author

pditommaso commented Mar 22, 2024

Thanks Ben

@pditommaso pditommaso changed the base branch from 3502-use-secrets-with-include-config to master March 22, 2024 15:35
@pditommaso pditommaso merged commit 00c9f22 into master Mar 22, 2024
@pditommaso pditommaso deleted the 3502-use-secrets-with-include-config-v2 branch March 22, 2024 15:41
@jmuhlich jmuhlich mentioned this pull request Apr 23, 2024
Closed
@bentsherman bentsherman mentioned this pull request May 22, 2024
Merged
@bentsherman bentsherman mentioned this pull request Sep 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bentsherman bentsherman bentsherman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to use secrets in the includeConfig directive

2 participants

@pditommaso @bentsherman
⚡