Skip to content

set ForceGlobalBucketAccess to false if region or endpoint provided, to enable non amazon S3 buckets #5779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pditommaso merged 6 commits into from
Feb 24, 2025
Merged

set ForceGlobalBucketAccess to false if region or endpoint provided, to enable non amazon S3 buckets #5779

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
656c4ec
fix: set ForceGlobalBucketAccess false if region or endpoint provided
Feb 11, 2025
c7d0edd
Merge branch 'master' into fix/s3-with-custom-endpoint
mcolpus Feb 11, 2025
88c0080
Merge branch 'master' into fix/s3-with-custom-endpoint
mcolpus Feb 14, 2025
40002cf
Merge branch 'master' into fix/s3-with-custom-endpoint
mcolpus Feb 14, 2025
30c4e04
fix: set global based isCustomEndpoint
Feb 21, 2025
9e03a0e
Add comment [ci skip]
pditommaso Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/nf-amazon/src/main/nextflow/cloud/aws/nio/S3FileSystemProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,7 +835,7 @@ protected S3FileSystem createFileSystem(URI uri, AwsConfig awsConfig) {
ClientConfiguration clientConfig = createClientConfig(props);

final String bucketName = S3Path.bucketName(uri);
final boolean global = bucketName!=null;
final boolean global = bucketName!=null && awsConfig.getRegion() == null && props.getProperty("endpoint") == null;
Comment thread
pditommaso marked this conversation as resolved.
Outdated
final AwsClientFactory factory = new AwsClientFactory(awsConfig, globalRegion(awsConfig));
client = new S3Client(factory.getS3Client(clientConfig, global));

Expand Down
⚡