Add $schema ref to generated module spec#7056
Merged
bentsherman merged 1 commit intomasterfrom Apr 22, 2026
Merged
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
a6a9b4a to
fbec79d
Compare
pditommaso
reviewed
Apr 22, 2026
Member
pditommaso
left a comment
There was a problem hiding this comment.
Just realised, there's an implicit version on the path however the schema version is not defined explicitly anywhere
Member
Author
|
It's part of the I don't think there is a separate version property in JSON schema |
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
fbec79d to
ca9b671
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
$schemaproperty to the module spec which denotes the module schemaThe generated module spec always uses the new schema: https://github.com/nextflow-io/schemas/blob/main/module/v1/schema.json
So if the
$schemaisn't specified, you can assume it is the nf-core schema:https://github.com/nf-core/modules/blob/master/modules/meta-schema.json