Fix generation of resolvedConfig when params included in the configuration #7072
Merged
bentsherman merged 2 commits intomasterfrom Apr 24, 2026
Merged
Fix generation of resolvedConfig when params included in the configuration #7072bentsherman merged 2 commits intomasterfrom
bentsherman merged 2 commits intomasterfrom
Conversation
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
bentsherman
approved these changes
Apr 24, 2026
bentsherman
pushed a commit
that referenced
this pull request
Apr 28, 2026
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #7002
This pull request updates the configuration resolution in the Nextflow CLI to allow command-line parameters to be passed and correctly injected into the resolved configuration. This ensures that parameters provided via the CLI are reflected in the generated config and adds a corresponding test to verify this behavior.
Enhancements to configuration resolution:
ConfigBuilder.resolveConfigto accept acliParamsmap, allowing command-line parameters to be injected into the resolved configuration (ConfigBuilder.groovy,CmdRun.groovy). [1] [2]Testing improvements:
ConfigBuilderTest.groovyto verify that CLI parameters override config values and are correctly reflected in the resolved configuration output. [1] [2]