Propagate task.containerPlatform through Fusion#7074
Merged
pditommaso merged 1 commit intomasterfrom Apr 25, 2026
Merged
Conversation
The Fusion code path bypassed setPlatform on the container builder, so process.arch was silently dropped when Fusion was enabled. Thread the task container platform through FusionHelper.runWithContainer and apply it on the builder when present. Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
1 similar comment
✅ Deploy Preview for nextflow-docs-staging canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Fusion code path in
FusionHelper.runWithContainerbypassedsetPlatformon the container builder, soprocess.archwas silently dropped when Fusion was enabled.Thread
task.getContainerPlatform()throughFusionHelper.runWithContainerand apply it on the builder when present. The non-Fusion path already callssetPlatforminBashWrapperBuilder; this aligns the two.Affects every container engine under Fusion (docker, podman, sarus, apple-container, ...).
Test plan
FusionHelperTestasserts--platform linux/amd64appears in the emitted docker command when the platform is passed.FusionHelperTestcases (no platform) still pass — the new parameter defaults tonull../gradlew :nextflow:test --tests "nextflow.fusion.*" --tests "nextflow.container.*" --tests "nextflow.executor.local.*"passes.