Skip to content

Eslint fixes and adding a prettier config for JS formatting#1054

Closed
douglowder wants to merge 3 commits intonextstrain:masterfrom
douglowder:eslint-fix-prettierrc
Closed

Eslint fixes and adding a prettier config for JS formatting#1054
douglowder wants to merge 3 commits intonextstrain:masterfrom
douglowder:eslint-fix-prettierrc

Conversation

@douglowder
Copy link
Copy Markdown
Contributor

Description of proposed changes

  • Fix some existing eslint errors and warnings
  • Allow higher versions of node to be used
  • Add a config for the prettier JS formatter that is minimally invasive and compatible with the current .eslintrc being used

Testing

yarn run lint should return no errors.

Thank you for contributing to Nextstrain!

@jameshadfield
Copy link
Copy Markdown
Member

Thanks for this work -- I've heard about prettify but never used it, so this PR have me a chance to play with this. I ended up rebasing this PR onto master as branch "prettify". All in all, it changes pretty much every file in the repo! I need to read a bit more about this and have a think about whether this is the direction we want to go, vs enforcing a subset of these style rules via eslint.

@douglowder douglowder closed this Dec 22, 2021
coycatz added a commit to coycatz/auspice that referenced this pull request Apr 10, 2026
Update footer text color to darker shade

Nextstrain.org Improve styles for accessibility nextstrain#1054
coycatz added a commit to coycatz/auspice that referenced this pull request Apr 10, 2026
Update font weight to 400 for improved readability
@coycatz coycatz mentioned this pull request Apr 10, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants