Skip to content

Bug fixes and small aesthetic amendments - Round 2#106

Merged
drpatelh merged 22 commits intonf-core:devfrom
drpatelh:master
Oct 4, 2019
Merged

Bug fixes and small aesthetic amendments - Round 2#106
drpatelh merged 22 commits intonf-core:devfrom
drpatelh:master

Conversation

@drpatelh
Copy link
Copy Markdown
Member

@drpatelh drpatelh commented Oct 4, 2019

Many thanks to contributing to nf-core/chipseq!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/chipseq branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/chipseq/tree/master/.github/CONTRIBUTING.md

Trying to unify processes and logic with atacseq pipeline. Fixed bugs reported here and with atacseq pipeline too. See CHANGELOG.md.

@drpatelh drpatelh requested a review from a team October 4, 2019 14:54
@drpatelh
Copy link
Copy Markdown
Member Author

drpatelh commented Oct 4, 2019

Ok. Im going to merge this. Maybe do a proper review when merging to master.

@drpatelh drpatelh merged commit 6308c1b into nf-core:dev Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant