FIX: Strict syntax for vsc_kul_hasselt#1015
Open
nvnieuwk wants to merge 8 commits intonf-core:masterfrom
Open
Conversation
jfy133
approved these changes
Mar 29, 2026
Member
jfy133
left a comment
jfy133
left a comment
There was a problem hiding this comment.
That's complicated, but I trust you 😬
Member
|
@Joon-Klaps can you merge if tests on the infrastructure pass? |
Contributor
|
Was testing this a while ago, there were some nf-schema issues, I'll check again. |
55 tasks
8 tasks
Member
|
@Joon-Klaps any update on this one? |
maxulysse
changed the title
Contributor
|
No, we still havent found a good way to dynamically select the correct partition. I also cannot find the time atm to work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the config compatible with strict syntax.
@Joon-Klaps would you mind testing this out on the cluster? I'm not 100% sure the use of closures here is correct (even though it should work?)
You can run a quick test using the test profile of
rnavarsince that pipeline is strict syntax compatible.NXF_VER=26.01.1-edge NXF_SYNTAX_PARSER=v2 nextflow run nf-core/rnavar -r dev -profile test -c <path-to-this-config>Feel free to also test it with a pipeline you run without the strict syntax. To make sure that also still works.