-
Notifications
You must be signed in to change notification settings - Fork 356
[WIP] Update Cambridge config for current CSD3 partitions #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RaqManzano
merged 12 commits into
nf-core:master
from
RaqManzano:update-cambridge-config
May 5, 2026
Merged
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3439f0b
Update Cambridge config for current CSD3 partitions
RaqManzano 26327a3
Add Cambridge profile owner to CODEOWNERS
RaqManzano 65f2465
Modified Cambridge resource selection to a partition map and refined …
RaqManzano 5528e15
Added Cambridge module setup and SLURM executor tuning
RaqManzano d4ce305
prettier
RaqManzano f1eb218
Update Cambridge docs to use scratch paths
RaqManzano 47b2a78
Refined Cambridge beforeScript logic and polished partition documenta…
RaqManzano 31cc0df
Update docs/cambridge.md
RaqManzano aa15fe2
Updated Cambridge documentation
RaqManzano 88790b5
Refine Cambridge config defaults and expand runtime documentation
RaqManzano b8ab4c9
Merge branch 'master' into update-cambridge-config
RaqManzano 9325477
Merge branch 'master' into update-cambridge-config
RaqManzano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,80 @@ | ||
| // Description is overwritten with user specific flags | ||
| // nf-core/configs: Cambridge CSD3 cluster profile | ||
| // Available partitions: | ||
| // - icelake : 76 CPUs, 256 GB RAM | ||
| // - icelake-himem : 76 CPUs, 512 GB RAM | ||
| // - sapphire : 112 CPUs, 512 GB RAM | ||
| // | ||
| // The profile defaults to the broadly available `icelake` partition but allows | ||
| // users to override it with `--partition`. Walltime is inferred from the SLURM | ||
| // account name when possible: projects containing `-SL3-` use a 12 h cap, | ||
| // otherwise the profile assumes the common SL1/SL2 36 h limit. | ||
|
|
||
| params { | ||
| config_profile_description = 'Cambridge HPC cluster profile.' | ||
| // FIXME EmelineFavreau was the last to edit this | ||
| config_profile_contact = 'Andries van Tonder (ajv37@cam.ac.uk)' | ||
| config_profile_url = "https://docs.hpc.cam.ac.uk/hpc" | ||
| partition = null | ||
| project = null | ||
| max_memory = 192.GB | ||
| max_cpus = 56 | ||
| max_time = 12.h | ||
| config_profile_description = 'Cambridge HPC CSD3 cluster profile.' | ||
| config_profile_contact = 'Raquel Manzano (rm889@cam.ac.uk) and Andries van Tonder (ajv37@cam.ac.uk)' | ||
| config_profile_url = 'https://docs.hpc.cam.ac.uk/hpc' | ||
|
|
||
| partition = 'icelake' | ||
| project = null | ||
|
|
||
| // Compatibility with nf-core schema validation across pipeline versions. | ||
| schema_ignore_params = 'partition,project,max_memory,max_cpus,max_time,csd_time,csd_parts,csd_selected,validationSchemaIgnoreParams' | ||
| validationSchemaIgnoreParams = 'partition,project,max_memory,max_cpus,max_time,csd_time,csd_parts,csd_selected,schema_ignore_params,validationSchemaIgnoreParams' | ||
| } | ||
|
|
||
| validation { | ||
| ignoreParams = ['partition', 'project', 'max_memory', 'max_cpus', 'max_time', 'csd_time', 'csd_parts', 'csd_selected', 'schema_ignore_params', 'validationSchemaIgnoreParams'] | ||
| } | ||
|
|
||
| // Description is overwritten with user specific flags | ||
| params.csd_time = { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can this not go in the main
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I prefer to keep it separate from the main block as it is not really a param for the users. |
||
| params.project?.toUpperCase()?.contains('-SL3-') ? 12.h : 36.h | ||
| }.call() | ||
|
|
||
| params.csd_parts = [ | ||
| icelake : [memory: 256.GB, cpus: 76, time: params.csd_time], | ||
| 'icelake-himem': [memory: 512.GB, cpus: 76, time: params.csd_time], | ||
| sapphire : [memory: 512.GB, cpus: 112, time: params.csd_time] | ||
| ] | ||
|
|
||
| params.csd_selected = { | ||
| def selected = params.csd_parts[params.partition] | ||
|
|
||
| if (!selected) { | ||
| System.err.println("ERROR: cambridge params.partition must be one of 'icelake', 'icelake-himem', or 'sapphire' (got '${params.partition}').") | ||
| System.exit(1) | ||
| } | ||
|
|
||
| selected | ||
| }.call() | ||
|
|
||
| params.max_memory = params.csd_selected.memory | ||
| params.max_cpus = params.csd_selected.cpus | ||
| params.max_time = params.csd_selected.time | ||
|
|
||
| singularity { | ||
| enabled = true | ||
| autoMounts = true | ||
| } | ||
|
|
||
| process { | ||
| resourceLimits = [ | ||
| memory: 192.GB, | ||
| cpus: 56, | ||
| time: 12.h | ||
| ] | ||
| resourceLimits = params.csd_selected | ||
|
|
||
| beforeScript = ''' | ||
| . /etc/profile.d/modules.sh | ||
| module purge | ||
| module load rhel8/default-icl | ||
| ''' | ||
|
|
||
| executor = 'slurm' | ||
| clusterOptions = "-A ${params.project} -p ${params.partition}" | ||
| queue = params.partition | ||
| clusterOptions = { params.project ? "--account=${params.project}" : '' } | ||
| } | ||
|
|
||
| executor { | ||
| name = 'slurm' | ||
| queueSize = 200 | ||
| pollInterval = '5 min' | ||
| queueStatInterval = '5 min' | ||
| submitRateLimit = '10 sec' | ||
| exitReadTimeout = '30 min' | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these two really needed, line 26 seems to cover these already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could but this is to be more compatible with older pipelines that still look for
schema_ignore_paramsandvalidationSchemaIgnoreParams