Add profiles that should be shared with all pipelines to configs#71
Merged
maxulysse merged 2 commits intonf-core:masterfrom Nov 19, 2019
Merged
Add profiles that should be shared with all pipelines to configs#71maxulysse merged 2 commits intonf-core:masterfrom
maxulysse merged 2 commits intonf-core:masterfrom
Conversation
apeltzer
approved these changes
Nov 19, 2019
apeltzer
approved these changes
Nov 19, 2019
ewels
reviewed
Nov 25, 2019
| config_profile_url = 'https://aws.amazon.com/batch/' | ||
| } | ||
|
|
||
| aws.region = params.awsregion |
Member
There was a problem hiding this comment.
This line causes the tests to fail 😱
ewels
reviewed
Nov 25, 2019
|
|
||
| aws.region = params.awsregion | ||
| process.executor = 'awsbatch' | ||
| process.queue = params.awsqueue |
Member
There was a problem hiding this comment.
This line will also cause problems.
ewels
reviewed
Nov 25, 2019
| process.executor = 'awsbatch' | ||
| process.queue = params.awsqueue | ||
| executor.awscli = '/home/ec2-user/miniconda/bin/aws' | ||
| params.tracedir = './' No newline at end of file |
Member
There was a problem hiding this comment.
Any reason not to group this together with the other params at the top?
Member
Author
There was a problem hiding this comment.
None, I just copied the config file we had on sarek
This was referenced Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do think
testanddebugshould be the only profiles to be specified at the pipeline level.So I'd like to include the following profile here:
I still think
conda,dockerandsingularityshould be included there, but I agree that we can do that one first, and then we'll see.