Skip to content

Update pawsey_setonix.config#885

Merged
georgiesamaha merged 9 commits intonf-core:masterfrom
SarahBeecroft:patch-2
Jun 25, 2025
Merged

Update pawsey_setonix.config#885
georgiesamaha merged 9 commits intonf-core:masterfrom
SarahBeecroft:patch-2

Conversation

@SarahBeecroft
Copy link
Copy Markdown
Contributor

bug fixes


name: New Config
about: A new cluster config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml
  • OPTIONAL: Add your custom profile path and GitHub user name to .github/CODEOWNERS (**/<custom-profile>** @<github-username>)

@SarahBeecroft SarahBeecroft marked this pull request as draft April 11, 2025 06:59
Copy link
Copy Markdown
Contributor Author

@SarahBeecroft SarahBeecroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make linter happy

@SarahBeecroft SarahBeecroft marked this pull request as ready for review April 11, 2025 07:02
Comment thread conf/pawsey_setonix.config Outdated
@jfy133 jfy133 self-requested a review April 14, 2025 10:12
@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Apr 14, 2025

@nf-core-bot fix linting

@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Apr 14, 2025

If oyu're happy with my fix and tests pass, you can merge @SarahBeecroft

@SarahBeecroft
Copy link
Copy Markdown
Contributor Author

Thank you @jfy133 !!

@SarahBeecroft
Copy link
Copy Markdown
Contributor Author

Updated the config to respect slurm limits. These can still be overridden if needed. Thanks for the help above.

Comment thread conf/pawsey_setonix.config Outdated
@jfy133
Copy link
Copy Markdown
Member

jfy133 commented May 6, 2025

@SarahBeecroft just as a reminder, in this repository merging should be performed by the PR author once you have approval (as other community members cannot be responsible for the running of pipelines using the config on your infrastructure).

@SarahBeecroft
Copy link
Copy Markdown
Contributor Author

Thanks @jfy133 - I'm pretty rusty so thanks for the reminder.

@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Jun 18, 2025

@SarahBeecroft nudge to merge this! You have the OKS :)

@georgiesamaha
Copy link
Copy Markdown
Contributor

@jfy133 I work with Sarah, going to merge on her behalf :)

@georgiesamaha georgiesamaha merged commit b86ac94 into nf-core:master Jun 25, 2025
150 checks passed
@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Jun 25, 2025

Thsnks @georgiesamaha !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants