Skip to content

Render report when using dream#607

Merged
delfiterradas merged 17 commits intonf-core:devfrom
delfiterradas:render_dream
Jan 29, 2026
Merged

Render report when using dream#607
delfiterradas merged 17 commits intonf-core:devfrom
delfiterradas:render_dream

Conversation

@delfiterradas
Copy link
Copy Markdown

@delfiterradas delfiterradas commented Jan 12, 2026

Closes #604 and update of all modules and subworkflows.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@delfiterradas delfiterradas self-assigned this Jan 12, 2026
@delfiterradas delfiterradas changed the base branch from master to dev January 12, 2026 19:57
@nf-core nf-core deleted a comment from github-actions Bot Jan 12, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 12, 2026

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 955cecb

+| ✅ 378 tests passed       |+
#| ❔  10 tests were ignored |#
#| ❔   1 tests had warnings |#
!| ❗  20 tests had warnings |!
Details

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in nextflow.config: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • schema_lint - Parameter input is not defined in the correct subschema (input_output_options)
  • schema_description - No description provided in schema for parameter: deseq2_seed
  • schema_description - No description provided in schema for parameter: dream_p_value
  • schema_description - No description provided in schema for parameter: dream_lfc
  • schema_description - No description provided in schema for parameter: dream_confint
  • schema_description - No description provided in schema for parameter: dream_proportion
  • schema_description - No description provided in schema for parameter: dream_stdev_coef_lim
  • schema_description - No description provided in schema for parameter: dream_trend
  • schema_description - No description provided in schema for parameter: dream_robust
  • schema_description - No description provided in schema for parameter: dream_winsor_tail_p
  • schema_description - No description provided in schema for parameter: dream_ddf
  • schema_description - No description provided in schema for parameter: dream_reml
  • schema_description - No description provided in schema for parameter: dream_apply_voom
  • schema_description - No description provided in schema for parameter: dream_adjust_method

❔ Tests ignored:

  • files_exist - File is ignored: assets/multiqc_config.yml
  • nextflow_config - Config default ignored: params.report_file
  • nextflow_config - Config default ignored: params.logo_file
  • nextflow_config - Config default ignored: params.css_file
  • nextflow_config - Config default ignored: params.citations_file
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-differentialabundance_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-differentialabundance_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-differentialabundance_logo_dark.png
  • multiqc_config - multiqc_config

❔ Tests fixed:

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.1
  • Run at 2026-01-22 13:15:11

@grst
Copy link
Copy Markdown
Member

grst commented Jan 13, 2026

Why does dream not have a normalized matrix? When using voom it should generate a normalized matrix just as limma does.

@delfiterradas
Copy link
Copy Markdown
Author

Why does dream not have a normalized matrix? When using voom it should generate a normalized matrix just as limma does.

I am addressing this in nf-core/modules#9645.

@grst once dream generates a normalised matrix, does it still make sense that the rest of the pipeline should run even when not using voom with either limma or dream (that is, using only the raw matrix)? Or should the rest of the modules only run if a normalised matrix is created?

@grst
Copy link
Copy Markdown
Member

grst commented Jan 13, 2026

I think it should still run, even when voom is not in use.

@delfiterradas delfiterradas marked this pull request as ready for review January 21, 2026 19:56
@delfiterradas delfiterradas requested a review from grst January 21, 2026 20:02
Comment thread CHANGELOG.md Outdated
Comment thread conf/paramsheet.yaml Outdated
Copy link
Copy Markdown
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now :-)

@delfiterradas delfiterradas merged commit 0bf19f1 into nf-core:dev Jan 29, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report not rendering with DREAM

3 participants