Skip to content

Commit 47c016b

Browse files
authored
Merge pull request #548 from nf-core/timelimit-mods
Timelimit mods
2 parents 3158d35 + 92e7b1a commit 47c016b

12 files changed

Lines changed: 384 additions & 15 deletions

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
3333
* Added a `.dockstore.yml` config file for automatic workflow registration with [dockstore.org](https://dockstore.org/)
3434
* Updated template to nf-core/tools 1.10.2
3535
* [#544](https://github.com/nf-core/eager/pull/544) Add script to perform bam filtering on fragment length
36+
* [#456](https://github.com/nf-core/eager/pull/546) Bumps the base (default) runtime of all processes to 4 hours, and set shorter timelimits for test profiles (1 hour)
3637

3738
### `Fixed`
3839

conf/base.config

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
process {
1313
cpus = { check_max( 1 * task.attempt, 'cpus' ) }
1414
memory = { check_max( 7.GB * task.attempt, 'memory' ) }
15-
time = { check_max( 4.h * task.attempt, 'time' ) }
15+
time = { check_max( 24.h * task.attempt, 'time' ) }
1616

1717
errorStrategy = { task.exitStatus in [143,137,104,134,139] ? 'retry' : 'finish' }
1818
maxRetries = 3
@@ -23,43 +23,43 @@ process {
2323
withLabel:'sc_tiny'{
2424
cpus = { check_max( 1, 'cpus' ) }
2525
memory = { check_max( 1.GB * task.attempt, 'memory' ) }
26-
time = { check_max( 2.h * task.attempt, 'time' ) }
26+
time = { check_max( 4.h * task.attempt, 'time' ) }
2727
}
2828

2929
withLabel:'sc_small'{
3030
cpus = { check_max( 1, 'cpus' ) }
3131
memory = { check_max( 4.GB * task.attempt, 'memory' ) }
32-
time = { check_max( 2.h * task.attempt, 'time' ) }
32+
time = { check_max( 4.h * task.attempt, 'time' ) }
3333
}
3434

3535
withLabel:'sc_medium'{
3636
cpus = { check_max( 1, 'cpus' ) }
3737
memory = { check_max( 8.GB * task.attempt, 'memory' ) }
38-
time = { check_max( 2.h * task.attempt, 'time' ) }
38+
time = { check_max( 4.h * task.attempt, 'time' ) }
3939
}
4040

4141
withLabel:'mc_small'{
42-
cpus = { check_max( 2, 'cpus' ) }
42+
cpus = { check_max( 2 * task.attempt, 'cpus' ) }
4343
memory = { check_max( 4.GB * task.attempt, 'memory' ) }
44-
time = { check_max( 2.h * task.attempt, 'time' ) }
44+
time = { check_max( 4.h * task.attempt, 'time' ) }
4545
}
4646

4747
withLabel:'mc_medium' {
48-
cpus = { check_max( 4, 'cpus' ) }
48+
cpus = { check_max( 4 * task.attempt, 'cpus' ) }
4949
memory = { check_max( 8.GB * task.attempt, 'memory' ) }
50-
time = { check_max( 2.h * task.attempt, 'time' ) }
50+
time = { check_max( 4.h * task.attempt, 'time' ) }
5151
}
5252

5353
withLabel:'mc_large'{
54-
cpus = { check_max( 8, 'cpus' ) }
54+
cpus = { check_max( 8 * task.attempt, 'cpus' ) }
5555
memory = { check_max( 16.GB * task.attempt, 'memory' ) }
56-
time = { check_max( 2.h * task.attempt, 'time' ) }
56+
time = { check_max( 4.h * task.attempt, 'time' ) }
5757
}
5858

5959
withLabel:'mc_huge'{
60-
cpus = { check_max( 32, 'cpus' ) }
60+
cpus = { check_max( 32 * task.attempt, 'cpus' ) }
6161
memory = { check_max( 256.GB * task.attempt, 'memory' ) }
62-
time = { check_max( 2.h * task.attempt, 'time' ) }
62+
time = { check_max( 4.h * task.attempt, 'time' ) }
6363
}
6464

6565
// Process-specific resource requirements (others leave at default, e.g. Fastqc)

conf/benchmarking_pathogenscreening.config

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@
88
*/
99

1010
params {
11-
config_profile_name = 'AWS Megatest Pathogen Screening profile'
12-
config_profile_description = "An AWS 'megatest' for testing complex sequencing aDNA data for human genome mapping and pathogen screening"
13-
name = "nf-core_eager_awsmegatest_pathogenscreening"
11+
config_profile_name = 'nf-core/eager benchmarking - pathogen screening profile'
12+
config_profile_description = "A 'fullsized' benchmarking profile for deep screening pathogen aDNA data"
1413

1514
//Input data
1615
input = 'https://github.com/nf-core/test-datasets/raw/eager/testdata/Benchmarking/benchmarking_pathogenscreening.tsv'

conf/test.config

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,49 @@ params {
2020
// Genome references
2121
fasta = 'https://raw.githubusercontent.com/nf-core/test-datasets/eager/reference/Mammoth/Mammoth_MT_Krause.fasta'
2222
}
23+
24+
process {
25+
26+
withLabel:'sc_tiny'{
27+
cpus = { check_max( 1, 'cpus' ) }
28+
memory = { check_max( 1.GB * task.attempt, 'memory' ) }
29+
time = { check_max( 1.h * task.attempt, 'time' ) }
30+
}
31+
32+
withLabel:'sc_small'{
33+
cpus = { check_max( 1, 'cpus' ) }
34+
memory = { check_max( 4.GB * task.attempt, 'memory' ) }
35+
time = { check_max( 1.h * task.attempt, 'time' ) }
36+
}
37+
38+
withLabel:'sc_medium'{
39+
cpus = { check_max( 1, 'cpus' ) }
40+
memory = { check_max( 8.GB * task.attempt, 'memory' ) }
41+
time = { check_max( 1.h * task.attempt, 'time' ) }
42+
}
43+
44+
withLabel:'mc_small'{
45+
cpus = { check_max( 2 * task.attempt, 'cpus' ) }
46+
memory = { check_max( 4.GB * task.attempt, 'memory' ) }
47+
time = { check_max( 1.h * task.attempt, 'time' ) }
48+
}
49+
50+
withLabel:'mc_medium' {
51+
cpus = { check_max( 4 * task.attempt, 'cpus' ) }
52+
memory = { check_max( 8.GB * task.attempt, 'memory' ) }
53+
time = { check_max( 1.h * task.attempt, 'time' ) }
54+
}
55+
56+
withLabel:'mc_large'{
57+
cpus = { check_max( 8 * task.attempt, 'cpus' ) }
58+
memory = { check_max( 16.GB * task.attempt, 'memory' ) }
59+
time = { check_max( 1.h * task.attempt, 'time' ) }
60+
}
61+
62+
withLabel:'mc_huge'{
63+
cpus = { check_max( 32 * task.attempt, 'cpus' ) }
64+
memory = { check_max( 256.GB * task.attempt, 'memory' ) }
65+
time = { check_max( 1.h * task.attempt, 'time' ) }
66+
}
67+
68+
}

conf/test_full.config

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ params {
3131
}
3232

3333
process {
34+
3435
withName:'adapter_removal'{
3536
cpus = { check_max( 8, 'cpus' ) }
3637
memory = { check_max( 16.GB * task.attempt, 'memory' ) }

conf/test_tsv.config

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,49 @@ params {
2020
// Genome references
2121
fasta = 'https://raw.githubusercontent.com/nf-core/test-datasets/eager/reference/Mammoth/Mammoth_MT_Krause.fasta'
2222
}
23+
24+
process {
25+
26+
withLabel:'sc_tiny'{
27+
cpus = { check_max( 1, 'cpus' ) }
28+
memory = { check_max( 1.GB * task.attempt, 'memory' ) }
29+
time = { check_max( 1.h * task.attempt, 'time' ) }
30+
}
31+
32+
withLabel:'sc_small'{
33+
cpus = { check_max( 1, 'cpus' ) }
34+
memory = { check_max( 4.GB * task.attempt, 'memory' ) }
35+
time = { check_max( 1.h * task.attempt, 'time' ) }
36+
}
37+
38+
withLabel:'sc_medium'{
39+
cpus = { check_max( 1, 'cpus' ) }
40+
memory = { check_max( 8.GB * task.attempt, 'memory' ) }
41+
time = { check_max( 1.h * task.attempt, 'time' ) }
42+
}
43+
44+
withLabel:'mc_small'{
45+
cpus = { check_max( 2 * task.attempt, 'cpus' ) }
46+
memory = { check_max( 4.GB * task.attempt, 'memory' ) }
47+
time = { check_max( 1.h * task.attempt, 'time' ) }
48+
}
49+
50+
withLabel:'mc_medium' {
51+
cpus = { check_max( 4 * task.attempt, 'cpus' ) }
52+
memory = { check_max( 8.GB * task.attempt, 'memory' ) }
53+
time = { check_max( 1.h * task.attempt, 'time' ) }
54+
}
55+
56+
withLabel:'mc_large'{
57+
cpus = { check_max( 8 * task.attempt, 'cpus' ) }
58+
memory = { check_max( 16.GB * task.attempt, 'memory' ) }
59+
time = { check_max( 1.h * task.attempt, 'time' ) }
60+
}
61+
62+
withLabel:'mc_huge'{
63+
cpus = { check_max( 32 * task.attempt, 'cpus' ) }
64+
memory = { check_max( 256.GB * task.attempt, 'memory' ) }
65+
time = { check_max( 1.h * task.attempt, 'time' ) }
66+
}
67+
68+
}

conf/test_tsv_bam.config

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,50 @@ params {
1919
input = 'https://raw.githubusercontent.com/nf-core/test-datasets/eager/testdata/Mammoth/mammoth_design_bam.tsv'
2020
// Genome references
2121
fasta = 'https://raw.githubusercontent.com/nf-core/test-datasets/eager/reference/Mammoth/Mammoth_MT_Krause.fasta'
22+
}
23+
24+
process {
25+
26+
withLabel:'sc_tiny'{
27+
cpus = { check_max( 1, 'cpus' ) }
28+
memory = { check_max( 1.GB * task.attempt, 'memory' ) }
29+
time = { check_max( 1.h * task.attempt, 'time' ) }
30+
}
31+
32+
withLabel:'sc_small'{
33+
cpus = { check_max( 1, 'cpus' ) }
34+
memory = { check_max( 4.GB * task.attempt, 'memory' ) }
35+
time = { check_max( 1.h * task.attempt, 'time' ) }
36+
}
37+
38+
withLabel:'sc_medium'{
39+
cpus = { check_max( 1, 'cpus' ) }
40+
memory = { check_max( 8.GB * task.attempt, 'memory' ) }
41+
time = { check_max( 1.h * task.attempt, 'time' ) }
42+
}
43+
44+
withLabel:'mc_small'{
45+
cpus = { check_max( 2 * task.attempt, 'cpus' ) }
46+
memory = { check_max( 4.GB * task.attempt, 'memory' ) }
47+
time = { check_max( 1.h * task.attempt, 'time' ) }
48+
}
49+
50+
withLabel:'mc_medium' {
51+
cpus = { check_max( 4 * task.attempt, 'cpus' ) }
52+
memory = { check_max( 8.GB * task.attempt, 'memory' ) }
53+
time = { check_max( 1.h * task.attempt, 'time' ) }
54+
}
55+
56+
withLabel:'mc_large'{
57+
cpus = { check_max( 8 * task.attempt, 'cpus' ) }
58+
memory = { check_max( 16.GB * task.attempt, 'memory' ) }
59+
time = { check_max( 1.h * task.attempt, 'time' ) }
60+
}
61+
62+
withLabel:'mc_huge'{
63+
cpus = { check_max( 32 * task.attempt, 'cpus' ) }
64+
memory = { check_max( 256.GB * task.attempt, 'memory' ) }
65+
time = { check_max( 1.h * task.attempt, 'time' ) }
66+
}
67+
2268
}

conf/test_tsv_complex.config

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,49 @@ params {
2020
// Genome references
2121
fasta = 'https://raw.githubusercontent.com/nf-core/test-datasets/eager/reference/Mammoth/Mammoth_MT_Krause.fasta'
2222
}
23+
24+
process {
25+
26+
withLabel:'sc_tiny'{
27+
cpus = { check_max( 1, 'cpus' ) }
28+
memory = { check_max( 1.GB * task.attempt, 'memory' ) }
29+
time = { check_max( 1.h * task.attempt, 'time' ) }
30+
}
31+
32+
withLabel:'sc_small'{
33+
cpus = { check_max( 1, 'cpus' ) }
34+
memory = { check_max( 4.GB * task.attempt, 'memory' ) }
35+
time = { check_max( 1.h * task.attempt, 'time' ) }
36+
}
37+
38+
withLabel:'sc_medium'{
39+
cpus = { check_max( 1, 'cpus' ) }
40+
memory = { check_max( 8.GB * task.attempt, 'memory' ) }
41+
time = { check_max( 1.h * task.attempt, 'time' ) }
42+
}
43+
44+
withLabel:'mc_small'{
45+
cpus = { check_max( 2 * task.attempt, 'cpus' ) }
46+
memory = { check_max( 4.GB * task.attempt, 'memory' ) }
47+
time = { check_max( 1.h * task.attempt, 'time' ) }
48+
}
49+
50+
withLabel:'mc_medium' {
51+
cpus = { check_max( 4 * task.attempt, 'cpus' ) }
52+
memory = { check_max( 8.GB * task.attempt, 'memory' ) }
53+
time = { check_max( 1.h * task.attempt, 'time' ) }
54+
}
55+
56+
withLabel:'mc_large'{
57+
cpus = { check_max( 8 * task.attempt, 'cpus' ) }
58+
memory = { check_max( 16.GB * task.attempt, 'memory' ) }
59+
time = { check_max( 1.h * task.attempt, 'time' ) }
60+
}
61+
62+
withLabel:'mc_huge'{
63+
cpus = { check_max( 32 * task.attempt, 'cpus' ) }
64+
memory = { check_max( 256.GB * task.attempt, 'memory' ) }
65+
time = { check_max( 1.h * task.attempt, 'time' ) }
66+
}
67+
68+
}

conf/test_tsv_fna.config

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,50 @@ params {
1919
input = 'https://raw.githubusercontent.com/nf-core/test-datasets/eager/testdata/Mammoth/mammoth_design_fastq.tsv'
2020
// Genome references
2121
fasta = 'https://raw.githubusercontent.com/nf-core/test-datasets/eager/reference/Mammoth/Mammoth_MT_Krause.fna'
22+
}
23+
24+
process {
25+
26+
withLabel:'sc_tiny'{
27+
cpus = { check_max( 1, 'cpus' ) }
28+
memory = { check_max( 1.GB * task.attempt, 'memory' ) }
29+
time = { check_max( 1.h * task.attempt, 'time' ) }
30+
}
31+
32+
withLabel:'sc_small'{
33+
cpus = { check_max( 1, 'cpus' ) }
34+
memory = { check_max( 4.GB * task.attempt, 'memory' ) }
35+
time = { check_max( 1.h * task.attempt, 'time' ) }
36+
}
37+
38+
withLabel:'sc_medium'{
39+
cpus = { check_max( 1, 'cpus' ) }
40+
memory = { check_max( 8.GB * task.attempt, 'memory' ) }
41+
time = { check_max( 1.h * task.attempt, 'time' ) }
42+
}
43+
44+
withLabel:'mc_small'{
45+
cpus = { check_max( 2 * task.attempt, 'cpus' ) }
46+
memory = { check_max( 4.GB * task.attempt, 'memory' ) }
47+
time = { check_max( 1.h * task.attempt, 'time' ) }
48+
}
49+
50+
withLabel:'mc_medium' {
51+
cpus = { check_max( 4 * task.attempt, 'cpus' ) }
52+
memory = { check_max( 8.GB * task.attempt, 'memory' ) }
53+
time = { check_max( 1.h * task.attempt, 'time' ) }
54+
}
55+
56+
withLabel:'mc_large'{
57+
cpus = { check_max( 8 * task.attempt, 'cpus' ) }
58+
memory = { check_max( 16.GB * task.attempt, 'memory' ) }
59+
time = { check_max( 1.h * task.attempt, 'time' ) }
60+
}
61+
62+
withLabel:'mc_huge'{
63+
cpus = { check_max( 32 * task.attempt, 'cpus' ) }
64+
memory = { check_max( 256.GB * task.attempt, 'memory' ) }
65+
time = { check_max( 1.h * task.attempt, 'time' ) }
66+
}
67+
2268
}

conf/test_tsv_humanbam.config

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,49 @@ params {
2424
pileupcaller_bedfile = 'https://raw.githubusercontent.com/nf-core/test-datasets/eager/reference/Human/1240K.pos.list_hs37d5.0based.bed.gz'
2525
pileupcaller_snpfile = 'https://raw.githubusercontent.com/nf-core/test-datasets/eager/reference/Human/1240K_covered_in_JK2067_downsampled_s0.1.numeric_chromosomes.snp'
2626
}
27+
28+
process {
29+
30+
withLabel:'sc_tiny'{
31+
cpus = { check_max( 1, 'cpus' ) }
32+
memory = { check_max( 1.GB * task.attempt, 'memory' ) }
33+
time = { check_max( 1.h * task.attempt, 'time' ) }
34+
}
35+
36+
withLabel:'sc_small'{
37+
cpus = { check_max( 1, 'cpus' ) }
38+
memory = { check_max( 4.GB * task.attempt, 'memory' ) }
39+
time = { check_max( 1.h * task.attempt, 'time' ) }
40+
}
41+
42+
withLabel:'sc_medium'{
43+
cpus = { check_max( 1, 'cpus' ) }
44+
memory = { check_max( 8.GB * task.attempt, 'memory' ) }
45+
time = { check_max( 1.h * task.attempt, 'time' ) }
46+
}
47+
48+
withLabel:'mc_small'{
49+
cpus = { check_max( 2 * task.attempt, 'cpus' ) }
50+
memory = { check_max( 4.GB * task.attempt, 'memory' ) }
51+
time = { check_max( 1.h * task.attempt, 'time' ) }
52+
}
53+
54+
withLabel:'mc_medium' {
55+
cpus = { check_max( 4 * task.attempt, 'cpus' ) }
56+
memory = { check_max( 8.GB * task.attempt, 'memory' ) }
57+
time = { check_max( 1.h * task.attempt, 'time' ) }
58+
}
59+
60+
withLabel:'mc_large'{
61+
cpus = { check_max( 8 * task.attempt, 'cpus' ) }
62+
memory = { check_max( 16.GB * task.attempt, 'memory' ) }
63+
time = { check_max( 1.h * task.attempt, 'time' ) }
64+
}
65+
66+
withLabel:'mc_huge'{
67+
cpus = { check_max( 32 * task.attempt, 'cpus' ) }
68+
memory = { check_max( 256.GB * task.attempt, 'memory' ) }
69+
time = { check_max( 1.h * task.attempt, 'time' ) }
70+
}
71+
72+
}

0 commit comments

Comments
 (0)