Conversation
|
apeltzer
requested changes
Sep 11, 2020
| cpus = { check_max( 1, 'cpus' ) } | ||
| memory = { check_max( 1.GB * task.attempt, 'memory' ) } | ||
| time = { check_max( 2.h * task.attempt, 'time' ) } | ||
| time = { check_max( 24.h * task.attempt, 'time' ) } |
Member
There was a problem hiding this comment.
Shouldn't tiny jobs not also be less than 24hours? e.g. lets say 3 for tiny, 6 for small, 8 for medium and 16 for large?
Member
There was a problem hiding this comment.
My fear here is that some clusters actually send you to the end of the queue if you ask for more hours than you actually need - so it shouldn't be set to too much more than the initial process will most likely need.
Member
Author
There was a problem hiding this comment.
Tiny is actually referring to the resources rather than time (at least in the eager concept).
Hmm ok. That's tricky then. I originally honestly felt 2.h was enough but #545 made me realise this could occur when people run their own data. Maybe 4.h for everything? Half a day I think would be pretty solid for testing with your own data... (run at 8, check again at lunch?).
Get final python script version
apeltzer
approved these changes
Sep 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nf-core/eager pull request
This PR is to close #546. When users move on from the small tests, they may want to run their own test on 'real sized' data, which may exceed 2.h base walltimes. This bumps this up to 24.h, and sets limits for specific profiles (1h, to also speed up during CI pipeline exiting if crashes occur, given most test runs take ~2m)
This includes changes from #544 , please merge that first (sorry, wrong checkout procedure...)
PR checklist
nextflow run . -profile test,docker --paired_end).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: CONTRIBUTING.md